Merge pull request #1943 from hstastna/BZ_The_text_improvement_SSH_ov…

…er_NodePort CNV-39558: Add tooltip for disabled SSH over NodePort option
kubevirt-ui · May 15, 2024 · 325cab9 · 325cab9
2 parents 8ccc03e + a44985b
commit 325cab9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/locales/en/plugin__kubevirt-plugin.json b/locales/en/plugin__kubevirt-plugin.json
@@ -842,6 +842,7 @@
   "Node labels": "Node labels",
   "Node port": "Node port",
   "Node selector": "Node selector",
+  "NodePort service is disabled. Ask your cluster admin to enable it in cluster settings.": "NodePort service is disabled. Ask your cluster admin to enable it in cluster settings.",
   "Nodes": "Nodes",
   "None": "None",
   "Not available": "Not available",

diff --git a/src/utils/components/SSHAccess/components/SSHServiceSelect.tsx b/src/utils/components/SSHAccess/components/SSHServiceSelect.tsx
@@ -65,8 +65,15 @@ const SSHServiceSelect: FC<SSHServiceSelectProps> = ({
             'Opens a specific port on all Nodes in the cluster. If the Node is publicly accessible, any traffic sent to this port is forwarded to the Service.',
           )}
           id={SERVICE_TYPES.NODE_PORT}
-          isDisabled={!nodePortEnabled}
+          isAriaDisabled={!nodePortEnabled}
           value={SERVICE_TYPES.NODE_PORT}
+          {...(!nodePortEnabled && {
+            tooltipProps: {
+              content: t(
+                'NodePort service is disabled. Ask your cluster admin to enable it in cluster settings.',
+              ),
+            },
+          })}
         >
           {serviceTypeTitles.NodePort}
         </SelectOption>