Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade K8s dependency lib to v0.21 #1985

Merged
merged 11 commits into from Aug 3, 2021

Conversation

wonderflow
Copy link
Collaborator

@wonderflow wonderflow commented Jul 29, 2021

What this PR does and Why?

  1. Upgrade controller-runtime to v0.9.3 which matches the K8s v1.21.x. Our old version(v0.2.x) matches with K8s version v1.16 which is already not maintained any more. The community maintained K8s version is v1.19~v1.21. There're potential security risks if we don't upgrade these dependency. Fix Bump helm.sh/helm/v3 from 3.2.4 to 3.6.1 #1972

  2. Why not upgrade to controller-runtime v0.8.x which matches to K8s v1.20.x?

  3. Upgrade crossplane-runtime and other dependency libraries to match the new version of controller-runtime.

  4. Fix a lot of incompatible changes.

    • field Object can not be decoded in runtime.RawExtension, so we need to marshal it as raw bytes into the Raw field.
    • longer the timeout duration to 1min for apiserver and etcd to be started
    • longer the suittest BeforeSuit function timeout to 120s
  5. Upgrade github action to matches with the new version

         uses: RyanSiu1995/kubebuilder-action@v1.2
         with:
           version: 3.1.0
           kubebuilderOnly: false
           kubernetesVersion: v1.21.2
    

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1985 (f46f312) into master (7a1f957) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1985      +/-   ##
==========================================
- Coverage   63.88%   63.87%   -0.01%     
==========================================
  Files         159      159              
  Lines       14972    14975       +3     
==========================================
+ Hits         9565     9566       +1     
- Misses       4436     4440       +4     
+ Partials      971      969       -2     
Flag Coverage Δ
e2e-rollout-tests 28.71% <ø> (-0.05%) ⬇️
e2etests 38.13% <ø> (+0.24%) ⬆️
unittests 59.29% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/controller/common/context.go 100.00% <ø> (ø)
...n/rollout/workloads/cloneset_rollout_controller.go 88.75% <ø> (ø)
...mon/rollout/workloads/cloneset_scale_controller.go 91.82% <ø> (ø)
.../common/rollout/workloads/delopyment_controller.go 77.50% <ø> (ø)
...rollout/workloads/deployment_rollout_controller.go 88.18% <ø> (ø)
...common/rollout/workloads/statefulset_controller.go 71.05% <ø> (ø)
...v1alpha2/appdeployment/appdeployment_controller.go 53.33% <ø> (ø)
...dev/v1alpha2/application/application_controller.go 81.81% <ø> (ø)
...troller/core.oam.dev/v1alpha2/application/apply.go 81.64% <ø> (ø)
....oam.dev/v1alpha2/application/dispatch/dispatch.go 74.50% <ø> (-3.35%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a1f957...f46f312. Read the comment docs.

@captainroy-hy
Copy link
Collaborator

Maybe this tool can help to install evntest binaries.

@wonderflow wonderflow force-pushed the upgrade-controller branch 6 times, most recently from 7904d9e to 9e71579 Compare August 1, 2021 09:03
@captainroy-hy captainroy-hy mentioned this pull request Aug 2, 2021
@wonderflow wonderflow force-pushed the upgrade-controller branch 3 times, most recently from 29c2b8e to 7afcb6f Compare August 2, 2021 08:31
Copy link
Collaborator

@captainroy-hy captainroy-hy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGMT

Copy link
Member

@hongchaodeng hongchaodeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please write a doc to tell contributors how to upgrade kubebuilder and test environment.

@wonderflow wonderflow merged commit aa87d3d into kubevela:master Aug 3, 2021
@wonderflow wonderflow deleted the upgrade-controller branch August 3, 2021 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants