Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix tests #1999

Merged
merged 1 commit into from
Aug 2, 2021
Merged

quick fix tests #1999

merged 1 commit into from
Aug 2, 2021

Conversation

captainroy-hy
Copy link
Collaborator

Signed-off-by: Yue Wang seiwy2010@gmail.com

What this PR does / why we need it:

fix tests that may fail after upgrading to k8s 1.21, related to #1985

Signed-off-by: Yue Wang <seiwy2010@gmail.com>
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #1999 (ade0bcb) into master (9d6aaa6) will increase coverage by 2.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1999      +/-   ##
==========================================
+ Coverage   61.59%   63.98%   +2.39%     
==========================================
  Files         158      158              
  Lines       14960    14960              
==========================================
+ Hits         9214     9572     +358     
+ Misses       4771     4422     -349     
+ Partials      975      966       -9     
Flag Coverage Δ
e2e-rollout-tests 28.84% <ø> (?)
e2etests 38.10% <ø> (+0.15%) ⬆️
unittests 59.28% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponentdefinition/componentdefinition_controller.go 77.14% <0.00%> (-9.53%) ⬇️
...es/policydefinition/policydefinition_controller.go 71.71% <0.00%> (-5.06%) ⬇️
...g/controller/core.oam.dev/v1alpha2/core/revison.go 50.33% <0.00%> (-2.65%) ⬇️
...ller/core.oam.dev/v1alpha2/application/revision.go 81.55% <0.00%> (-0.49%) ⬇️
...aits/traitdefinition/traitdefinition_controller.go 80.55% <0.00%> (ø)
apis/core.oam.dev/v1beta1/zz_generated.deepcopy.go 41.37% <0.00%> (+0.36%) ⬆️
...oam.dev/v1alpha2/applicationconfiguration/apply.go 66.81% <0.00%> (+0.90%) ⬆️
...ev/v1alpha2/core/scopes/healthscope/healthscope.go 91.41% <0.00%> (+1.01%) ⬆️
pkg/oam/util/helper.go 79.45% <0.00%> (+1.58%) ⬆️
...pplicationcontext/applicationcontext_controller.go 84.48% <0.00%> (+1.72%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d6aaa6...ade0bcb. Read the comment docs.

@wonderflow wonderflow merged commit b4ebdac into kubevela:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants