Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 to shlex #300

Closed
wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Jan 29, 2024

What type of PR is this?
https://github.com/google/shlex is archived, so we may maintain it here.

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:
xref kubernetes-sigs/kustomize#4963 and kubernetes/kubernetes#114912

Special notes for your reviewer:

Since https://github.com/google/shlex is archived, we added it to unwanted dep list.
However, before we have requirements to change it, we may keep it as is.

This may be a fix later if we have new requirement on shlex.

Release note:

Add google/shlex that is archived

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pacoxu
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 29, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Jan 29, 2024

/close
Since https://github.com/google/shlex is archived, we added it to unwanted dep list.
However, before we have requirements to change it, we may keep it as is.

This may be a fix later if we have new requirement on shlex.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

/close
Since https://github.com/google/shlex is archived, we added it to unwanted dep list.
However, before we have requirements to change it, we may keep it as is.

This may be a fix later if we have new requirement on shlex.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants