google/shlex is archived

[pacoxu]

kustomize/api/go.mod

Line 8 in 9bc75c1

github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510

follow up of kubernetes/kubernetes#114912

github.com/google/shlex is archived.

[pacoxu]

I cannot find a valid replacement for this.

• https://github.com/anmitsu/go-shlex is newer but has not been updated since 2020 and has no releases.

[KnVerey]

Hmm, I guess we'll have to look more deeply at what we use this for. There is only one usage:

kustomize/api/internal/plugins/execplugin/execplugin.go

Line 96 in 8ab4b8d

p.args, _ = shlex.Split(c.ArgsOneLiner)

/triage accepted
/kind cleanup

[pacoxu]

Not sure if https://pkg.go.dev/mvdan.cc/sh/v3@v3.6.0/shell can help in this case.

[k8s-triage-robot]

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

• Confirm that this issue is still relevant with /triage accepted (org members only)
• Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

[pacoxu]

#5006 (comment) may be a workaround to maintain it in util.

[pacoxu]

kubernetes/utils#300 may be a fix, but as we have no new requirements on it. I prefer to do nothing now.

[pohly]

Hmm, I guess we'll have to look more deeply at what we use this for. There is only one usage:

kustomize/api/internal/plugins/execplugin/execplugin.go

Line 96 in 8ab4b8d

p.args, _ = shlex.Split(c.ArgsOneLiner)

Note that google/shlex does not handle POSIX correctly:
https://go.dev/play/p/jiQpbBDQGUD

package main

import (
	"fmt"

	"github.com/google/shlex"
)

func main() {
	args, _ := shlex.Split(`"\[Flaky\]"`)
	fmt.Printf("%q", args)

	// Prints ["[Flaky]"], should be ["\\[Flaky\\]"] because
	// a shell (bash in my case) leaves the backslash in place:
	// $ echo "\[Flaky\]"
	// \[Flaky\]
}

github.com/anmitsu/go-shlex handles this when using POSIX mode.