Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IN_CLOEXEC when creating notify watches. #101

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Use IN_CLOEXEC when creating notify watches. #101

merged 1 commit into from
Jul 12, 2019

Conversation

cpuguy83
Copy link
Contributor

@cpuguy83 cpuguy83 commented Jul 12, 2019 •
edited

This prevents potential inotify FD leaks to sub-processes.

Related to kubernetes/kubernetes#75526

@cpuguy83
Use IN_CLOEXEC when creating notify watches.
21c7580 
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
@k8s-ci-robot
Copy link
Contributor

Welcome @cpuguy83!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2019
@cpuguy83 cpuguy83 mentioned this pull request Jul 12, 2019
Closed
5 tasks
@dims
Copy link
Member

dims commented Jul 12, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 12, 2019
@dims
Copy link
Member

dims commented Jul 12, 2019

/assign @dashpole

@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpuguy83, dashpole, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 809904c into kubernetes:master Jul 12, 2019
@cpuguy83 cpuguy83 deleted the inotify_cloexec branch July 12, 2019 20:15
@liggitt liggitt mentioned this pull request Jul 29, 2019
Merged
@dims
Copy link
Member

dims commented Aug 6, 2019

manual test - kubernetes/kubernetes#80689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@dims dims

@dashpole dashpole

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cpuguy83 @k8s-ci-robot @dims @dashpole