Switch to k8s.io/utils/inotify

[Pothulapati]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Replaces github.com/go-sigma/inotify with k8s.io/utils/inotify

Which issue(s) this PR fixes:

Fixes #80092

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@dims

[k8s-ci-robot]

Hi @Pothulapati. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

Dupe of #80613
/close

[k8s-ci-robot]

@cblecker: Closed this PR.

In response to this:

Dupe of #80613
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

Actually, I just saw that this was intended.
/reopen

[k8s-ci-robot]

@cblecker: Reopened this PR.

In response to this:

Actually, I just saw that this was intended.
/reopen
/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cblecker]

/ok-to-test

[dims]

/priority important-soon
/milestone v1.16

[liggitt]

any tests in k8s.io/utils or in k8s to prove kubernetes/utils#101 fixes the leak?

was this answered?

[dims]

@liggitt hmm i thought i figured out, but missed adding a comment. Please see manual steps in the fsnotify PR which is very similar to this change

dims@bigbox:~/junk$ /bin/cat test.go
package main

import (
    "fmt"
    "log"
    "os"
    "os/exec"
    "time"

    "k8s.io/utils/inotify"
)

func main() {
    if len(os.Args) == 1 { // parent
        watcher, err := inotify.NewWatcher()
        if err != nil {
            log.Fatal(err)
        }
        defer watcher.Close()

        child := exec.Command(os.Args[0], "child")
        err = child.Start()
        if err != nil {
            log.Fatal(err)
        }

        fmt.Println("Parent", os.Getpid(), "child", child.Process.Pid)
    }

    fmt.Println(os.Args, "going into sleep")
    for {
        time.Sleep(time.Second)
    }
}

dims@bigbox:~/junk$ go run test.go
Parent 18870 child 18875
[/tmp/go-build617179765/b001/exe/test] going into sleep

dims@bigbox:~$ lsof -p 18870
COMMAND   PID USER   FD      TYPE DEVICE SIZE/OFF     NODE NAME
test    18870 dims  cwd       DIR  253,0     4096 41816258 /home/dims/junk
test    18870 dims  rtd       DIR  253,0     4096        2 /
test    18870 dims  txt       REG  253,0  1664448  1576577 /tmp/go-build617179765/b001/exe/test
test    18870 dims    0u      CHR  136,0      0t0        3 /dev/pts/0
test    18870 dims    1u      CHR  136,0      0t0        3 /dev/pts/0
test    18870 dims    2u      CHR  136,0      0t0        3 /dev/pts/0
test    18870 dims    3r  a_inode   0,13        0    14824 inotify
test    18870 dims    5u  a_inode   0,13        0    14824 [eventpoll]
dims@bigbox:~$ lsof -p 18875
COMMAND   PID USER   FD   TYPE DEVICE SIZE/OFF     NODE NAME
test    18875 dims  cwd    DIR  253,0     4096 41816258 /home/dims/junk
test    18875 dims  rtd    DIR  253,0     4096        2 /
test    18875 dims  txt    REG  253,0  1664448  1576577 /tmp/go-build617179765/b001/exe/test
test    18875 dims    0r   CHR    1,3      0t0        6 /dev/null
test    18875 dims    1w   CHR    1,3      0t0        6 /dev/null
test    18875 dims    2w   CHR    1,3      0t0        6 /dev/null

[liggitt]

ok, glad there's a manual test. any possibility of an automated one? I won't block on it, but would like to at least see an issue for tracking that

[dims]

@liggitt Added an issue - kubernetes/utils#106

[liggitt]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, Pothulapati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Pothulapati]

Looks like #78610 , updated to use a more latest commig of k8s.io/utils and there were conflicts as this PR had an older commit.

I updated the PR, to use the latest commit of k8s.io/utils i.e same as the one in the PR. :)

[liggitt]

sorry for the churn. does this need to be rebased on master? It looks like this still has commits that conflict with #78610. If so, I'd recommend:

• rebasing on master, dropping the commits that mess with vendor
• run hack/update-vendor.sh and make a new commit (you shouldn't need to do any pin-dependency work any more)
• run hack/lint-dependencies.sh and make sure the results are clean

[Pothulapati]

Got it @liggitt, Thanks for the help!
Updated as per your comment :)

[liggitt]

thanks

/lgtm

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

[fejta-bot]

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.