Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default namespace labels to all namespaces for selectors #96968

Merged
merged 23 commits into from Mar 9, 2021
Merged

Add default namespace labels to all namespaces for selectors #96968

merged 23 commits into from Mar 9, 2021

Conversation

jayunit100
Copy link
Member

@jayunit100 jayunit100 commented Nov 30, 2020 •
edited by liggitt

What type of PR is this?

What this PR does / why we need it:

Adds a default label to all k8s namespaces on read

Which issue(s) this PR fixes:

kubernetes/enhancements#2162

Does this PR introduce a user-facing change?:

Namespace API objects now have a `kubernetes.io/metadata.name` label matching their metadata.name field to allow selecting any namespace by its name using a label selector.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 30, 2020
@jayunit100
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 30, 2020
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2020
@jayunit100 jayunit100 force-pushed the namespace-by-name-default-labels branch 2 times, most recently from 213aa83 to 7a48f77 Compare December 1, 2020 01:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 1, 2020
@jayunit100 jayunit100 force-pushed the namespace-by-name-default-labels branch from 063c0fc to 7a48f77 Compare December 1, 2020 01:44
@jayunit100
Copy link
Member Author

cc @thockin @abhiraut @rikatz @andrewsykim

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2020
@rikatz rikatz force-pushed the namespace-by-name-default-labels branch from b43eb73 to 4654742 Compare March 9, 2021 01:18
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@rikatz
Copy link
Contributor

rikatz commented Mar 9, 2021

/lgtm

can I lgtm when is just a rebase and I’m not the author? 🤔

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@rikatz
Copy link
Contributor

rikatz commented Mar 9, 2021

/lgtm

can I lgtm when is just a rebase and I’m not the author? 🤔

Yup, I can

@nikhita fyi, don’t know as I authored some of the commits if I should be able to lgtm here.

@jayunit100
Copy link
Member Author

Ok all set for merge then!?

@liggitt
Copy link
Member

liggitt commented Mar 9, 2021

yeah, CI is unhappy, but unrelated to this change

/retest

@rikatz
Copy link
Contributor

rikatz commented Mar 9, 2021

Maybe this still needs rebase? (The label is there and this might block the merge :/ )

@liggitt
Copy link
Member

liggitt commented Mar 9, 2021

rebased locally just fine... I think the label is stale

@liggitt liggitt added this to the v1.21 milestone Mar 9, 2021
@liggitt liggitt removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 9, 2021 •
edited

@jayunit100: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-bazel-test 9677e825cfe8569704f609570d800925fa0442cf link /test pull-kubernetes-bazel-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rikatz
Copy link
Contributor

rikatz commented Mar 9, 2021

/test pull-kubernetes-e2e-kind-ipv6
🤞

@k8s-ci-robot k8s-ci-robot merged commit c94ce8c into kubernetes:master Mar 9, 2021
@annajung annajung mentioned this pull request Mar 9, 2021
Closed
4 tasks
@aojea aojea mentioned this pull request Mar 13, 2021
Closed
@rikatz rikatz mentioned this pull request Apr 1, 2021
Merged
@mattfenwick mattfenwick mentioned this pull request Apr 9, 2021
Closed
5 tasks
@rosenhouse rosenhouse mentioned this pull request Apr 21, 2021
Merged
@vpnachev vpnachev mentioned this pull request Sep 28, 2022
Closed
@NikitaSkrynnik NikitaSkrynnik mentioned this pull request Dec 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@abhiraut abhiraut abhiraut left review comments

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@rikatz rikatz rikatz left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@mattfenwick mattfenwick

@liggitt liggitt

@knabben knabben

@thockin thockin

@rikatz rikatz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/gcp Issues or PRs related to gcp provider area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.21
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

None yet