Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

state validation fails due to new default namespace labels #91

Closed
2 of 5 tasks
mattfenwick opened this issue Apr 9, 2021 · 2 comments
Closed
2 of 5 tasks

state validation fails due to new default namespace labels #91

mattfenwick opened this issue Apr 9, 2021 · 2 comments

Comments

@mattfenwick
Copy link
Owner

mattfenwick commented Apr 9, 2021

This happens on newer kube versions, see: kubernetes/kubernetes#96968

Logs:
Untitled.txt

time="2021-04-09T09:52:57Z" level=fatal msg="for namespace y, expected labels map[ns:y] (found map[kubernetes.io/metadata.name:y ns:y])\n
github.com/mattfenwick/cyclonus/pkg/connectivity.(*TestCaseState).verifyClusterStateHelper
  /Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/connectivity/testcasestate.go:238
github.com/mattfenwick/cyclonus/pkg/connectivity.(*TestCaseState).VerifyClusterState
  /Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/connectivity/testcasestate.go:286
github.com/mattfenwick/cyclonus/pkg/connectivity.(*Interpreter).ExecuteTestCase
  /Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/connectivity/interpreter.go:85
github.com/mattfenwick/cyclonus/pkg/cli.RunGenerateCommand\n\t/Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/cli/generate.go:135\ngithub.com/mattfenwick/cyclonus/pkg/cli.SetupGenerateCommand.func1\n\t/Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/cli/generate.go:44\ngithub.com/spf13/cobra.
(*Command).execute\n\t/Users/mfenwick/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:846\ngithub.com/spf13/cobra.
(*Command).ExecuteC\n\t/Users/mfenwick/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:950\ngithub.com/spf13/cobra.
(*Command).Execute\n\t/Users/mfenwick/go/pkg/mod/github.com/spf13/cobra@v1.0.0/command.go:887\ngithub.com/mattfenwick/cyclonus/pkg/cli.RunRootCommand\n\t/Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/pkg/cli/root.go:13\nmain.main\n\t/Users/mfenwick/go/src/github.com/mattfenwick/cyclonus/cmd/cyclonus/main.go:8\nruntime.main\n\t/usr/local/Cellar/go/1.15.5/libexec/src/runtime/proc.go:204\nruntime.goexit\n\t/usr/local/Cellar/go/1.15.5/libexec/src/runtime/asm_amd64.s:1374"

TODOs:

  • get a cluster of 1.21 to repro this against
  • come up with some code that works on both <= 1.20 and >= 1.21
  • (maybe) just ignore extra labels
  • (maybe) detect cluster version and do the right thing automatically
  • (maybe) provide a CLI switch to turn on/off the labels
@mattfenwick
Copy link
Owner Author

see #119

@mattfenwick
Copy link
Owner Author

Resolution: read actual labels from kubernetes cluster, using those as the basis for the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant