Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update otelhttp dependency from v0.35.0 to v0.37.0 #115208

Closed
wants to merge 1 commit into from
Closed

Update otelhttp dependency from v0.35.0 to v0.37.0 #115208

wants to merge 1 commit into from

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Jan 19, 2023 •
edited

/kind bug

What this PR does / why we need it:

This bumps the otelhttp dependency from v0.35.0 to v0.37.0.

When API Server Tracing was enabled by default prior to the 1.26 release, it caused #113791. This was ultimately due to open-telemetry/opentelemetry-go-contrib#2982, which was fixed by open-telemetry/opentelemetry-go-contrib#2983, and released in otelhttp v0.37.0.

Which issue(s) this PR fixes:

Fixes the underlying problem from #113791.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/apiserver area/cloudprovider area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2023
@k8s-ci-robot k8s-ci-robot requested review from apelisse, dims and a team January 19, 2023 16:24
@dashpole
Copy link
Contributor Author

cc @logicalhan @dgrisonnet

@dims
Copy link
Member

dims commented Jan 19, 2023

looks like it needs something else

vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig/envconfig.go:84:13: undefined: envconfig.WithTLSConfig
vendor/go.opentelemetry.io/otel/exporters/otlp/otlptrace/internal/otlpconfig/envconfig.go:85:13: undefined: envconfig.WithTLSConfig

@cici37
Copy link
Contributor

cici37 commented Jan 19, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/code-generation area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dashpole
Once this PR has been reviewed and has the lgtm label, please assign liggitt, smarterclayton, soltysh, sttts for approval by writing /assign @liggitt @smarterclayton @soltysh @sttts in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 19, 2023
@k8s-ci-robot
Copy link
Contributor

@dashpole: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-dependencies f2f2b26 link true /test pull-kubernetes-dependencies
pull-kubernetes-node-e2e-containerd f2f2b26 link true /test pull-kubernetes-node-e2e-containerd
pull-kubernetes-conformance-kind-ga-only-parallel f2f2b26 link true /test pull-kubernetes-conformance-kind-ga-only-parallel
pull-kubernetes-unit f2f2b26 link true /test pull-kubernetes-unit
pull-kubernetes-e2e-kind-ipv6 f2f2b26 link true /test pull-kubernetes-e2e-kind-ipv6
pull-kubernetes-e2e-kind f2f2b26 link true /test pull-kubernetes-e2e-kind
pull-kubernetes-e2e-gce f2f2b26 link true /test pull-kubernetes-e2e-gce
pull-kubernetes-verify f2f2b26 link true /test pull-kubernetes-verify
pull-kubernetes-integration f2f2b26 link true /test pull-kubernetes-integration
pull-kubernetes-e2e-gce-100-performance f2f2b26 link true /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dashpole
Copy link
Contributor Author

Looks like this is blocked by #113366.

I'm going to close this for now, and retry once that makes progress.

@dashpole dashpole closed this Jan 19, 2023
@cici37
Copy link
Contributor

cici37 commented Jan 26, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2023
@dashpole dashpole mentioned this pull request Jan 30, 2023
Closed
@dashpole dashpole mentioned this pull request Feb 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@dims dims Awaiting requested review from dims

Assignees
No one assigned
Labels
area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dashpole @dims @cici37 @k8s-ci-robot