Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point release of go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.35.0 needed #3513

Closed
MrAlias opened this issue Feb 28, 2023 · 3 comments
Assignees

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Feb 28, 2023

In order to unblock the Kubernetes project, the fix from #2983 needs to be back-ported to v0.35.0 for the go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp package.

Proposal

  1. Create a branch from the v0.35.1 release
  2. Cherry-pick the fix from otelhttp: Treat http.NoBody the same as a nil body #2983 to that branch
  3. Tag the branch with instrumentation/net/http/otelhttp/v0.35.1
@MrAlias MrAlias self-assigned this Feb 28, 2023
@dashpole
Copy link
Contributor

The initial bug from upstream: kubernetes/kubernetes#113791. Because of that, the tracing feature in k8s is not useable until we get this fix.

I tried to update the otelhttp version here: kubernetes/kubernetes#115208 but discovered that it was blocked by kubernetes/kubernetes#113366, which looks like it will take a while to resolve.

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 28, 2023

I created the release-otelhttp-v0.35.1 for this.

@MrAlias
Copy link
Contributor Author

MrAlias commented Feb 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants