Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CEL size estimation #111964

Merged
merged 3 commits into from Aug 29, 2022
Merged

Fix CEL size estimation #111964

merged 3 commits into from Aug 29, 2022

Conversation

DangerOnTheRanger
Copy link
Contributor

@DangerOnTheRanger DangerOnTheRanger commented Aug 22, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR fixes #111769 by updating cel-go to v0.12.5, which includes a fix for the bug. The version bump also addresses google/cel-go#573. This PR also includes a couple unit tests to ensure both are fixed (the latter bug is something that affects k8s but was reported on cel-go). I'd like for this to make it into 1.25.1, if possible.

Which issue(s) this PR fixes:

Fixes #111769

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 22, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Mon Aug 22 13:43:42 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 22, 2022
@k8s-ci-robot k8s-ci-robot requested review from dchen1107, logicalhan and a team August 22, 2022 17:09
@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 22, 2022
@DangerOnTheRanger DangerOnTheRanger mentioned this pull request Aug 23, 2022
Merged
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2022
liggitt
liggitt reviewed Aug 25, 2022
View reviewed changes
go.mod Show resolved Hide resolved
@liggitt
Copy link
Member

liggitt commented Aug 25, 2022

just the one question about the glog backlevel, lgtm otherwise

@liggitt
Copy link
Member

liggitt commented Aug 29, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DangerOnTheRanger, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 3a4e3a0 into kubernetes:master Aug 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 29, 2022
@DangerOnTheRanger DangerOnTheRanger mentioned this pull request Aug 29, 2022
Merged
k8s-ci-robot added a commit that referenced this pull request Sep 7, 2022
@k8s-ci-robot
Merge pull request #112107 from DangerOnTheRanger/automated-cherry-pi…
bccdd19 
…ck-of-#111964-upstream-release-1.25

Automated cherry pick of #111964: Fix of #111769 for 1.25 release branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

CEL cost budgeting inconsistent rejections
4 participants
@DangerOnTheRanger @k8s-ci-robot @leilajal @liggitt