Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.24] Bump cel-go to v0.10.2 and add unit tests #111970

Merged
merged 2 commits into from
Sep 7, 2022
Merged

[1.24] Bump cel-go to v0.10.2 and add unit tests #111970

merged 2 commits into from
Sep 7, 2022

Conversation

DangerOnTheRanger
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Manual backport of #111964 to 1.24 (as 1.25 and 1.24 use different releases of cel-go, v0.10.2 includes the same fix as v0.12.5 as used in that PR). The unit tests added here are the exact same as in #111964 - please add review comments to that PR for the unit tests, and I'll mirror any changes here.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Again, please add review comments for the unit tests to #111964.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Aug 23, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/dependency Issues or PRs related to dependency changes labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot requested review from jpbetz, logicalhan and a team August 23, 2022 06:20
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2022
@DangerOnTheRanger
Copy link
Contributor Author

/retest

@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2022
@jpbetz
Copy link
Contributor

jpbetz commented Aug 23, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2022
@DangerOnTheRanger
Copy link
Contributor Author

/assign @smarterclayton

@aojea
Copy link
Member

aojea commented Aug 25, 2022

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Sep 7, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DangerOnTheRanger, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2022
@DangerOnTheRanger
Copy link
Contributor Author

/cc kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team September 7, 2022 17:00
@puerco
Copy link
Member

puerco commented Sep 7, 2022

Thanks @DangerOnTheRanger !
/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 7, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

@DangerOnTheRanger: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-conformance-kind-ga-only-parallel ead41cf link unknown /test pull-kubernetes-conformance-kind-ga-only-parallel

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@puerco
Copy link
Member

puerco commented Sep 7, 2022

Timed out
/test pull-kubernetes-conformance-kind-ga-only-parallel

@k8s-ci-robot k8s-ci-robot merged commit f890caa into kubernetes:release-1.24 Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbetz jpbetz Awaiting requested review from jpbetz

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@jpbetz jpbetz

@liggitt liggitt

@smarterclayton smarterclayton

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@DangerOnTheRanger @leilajal @jpbetz @aojea @liggitt @k8s-ci-robot @puerco @smarterclayton