scheduler: contextual logging - WithName and WithValue

[knelasevero]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This makes kube-scheduler log output more useful.

Which issue(s) this PR fixes:

Related-to: #91633 Built on top of #110833 (Just rebased latest changes)

Special notes for your reviewer:

The basic work is in the initial commit of that WIP PR. The other commits (in that WIP PR) start with full instrumentation and then gradually reduce the runtime overhead.

I chose to create this PR already pointing to the scheduler: use WithName and WithValues commit.

I ran the perf tests a few times, and yeah, we have some overhead, but I personally think it is worth it [?]. Whole idea was to have named loggers initially. I think this is a nice first step and we can go to the other more specific improvements after this.

I rebased changes from master here, and chose to use the FailureHandler that came from there. Please let me know if I did something wrong in this rebase.

After this gets merged there's some followup work to be done (when ctx logging hits GA): #111672

Does this PR introduce a user-facing change?

Migrated kube-scheduler to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

[k8s-ci-robot]

@knelasevero: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @knelasevero. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

/ok-to-test

[rikatz]

/sig scheduling

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[knelasevero]

/retest

[knelasevero]

@alculquicondor I don't see those changes here. The only change in cmd/ is because of changes in the scheduler.New inside of pkg/

[alculquicondor]

ah, I was confused by the changes in pkg/scheduler/apis/config/v1/default_plugins.go. I thought they had all merged in the previous PR.

[alculquicondor]

any chance you can split the PRs again (and maybe a few others too)? I have very limited time to review and maybe we won't be able to merge this entire PR, but we can still make progress.

[knelasevero]

Maybe someone from the community would want to take that task and push these splits of this PR forward? Since they can use this PR as reference it would be easy to anyone wanting to contribute (I can help, of course, but I may have to focus on some other things).

[alculquicondor]

/help

[knelasevero]

/help-wanted

[alculquicondor]

Maybe it doesn't work on PRs

[pohly]

@alculquicondor: any suggestion on how to split this up? By directories?

Looking at the commit history, all commits probably can be squashed into one, i.e. there are no commits which could be merged separately.

[alculquicondor]

Everything under pkg/scheduler/apis can be its own PR.

The rest is a bit unclear. Maybe it's possible to have a PR for each of the folders in pkg/scheduler/framework/plugins. Followed by a PR that does the rest.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knelasevero]

I had a look over kubernetes/enhancements#3077. Just tagging some people here to see if they want to pick this up:

@mengjiao-liu
@249043822
@Namanl2001
@ncdc
@sanwishe
@yangjunmyfm192085
@freddie400
@pravarag

Would any of you be interested in picking this one up? The work would mean basically splinting the changes of #111155 into multiple PRs, as described by @alculquicondor in #111155 (comment)

whoever picks this up can ignore the commit history here (#111155) and create new commits that make sense in each split PR.

[ncdc]

I might be able to do some, but I wouldn't be able to start on anything for at least 2 weeks

[alculquicondor]

code freeze is tomorrow, so I think the boat has sailed for this release.

[Namanl2001]

I would like to pick this up, but unfortunately, this won't be possible to be done in a couple of days

[mengjiao-liu]

I can help too, but time is too urgent before the code freeze, both for contributors and reviewers, maybe we can finish it in the next version.

[mengjiao-liu]

If we start the task, we need to figure out how to split PR.
I am not quite clear about the directory structure of the scheduler, so I will first divide PR from the direction provided by @alculquicondor and then adjust it according to the actual implementation.

Please see #91633 (comment).

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[mengjiao-liu]

/sig instrumentation
/wg structured-logging
/area logging

[mengjiao-liu]

Work continues in #91633 (comment)

/close

[k8s-ci-robot]

@mengjiao-liu: Closed this PR.

In response to this:

Work continues in #91633 (comment)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.