Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated pkg/scheduler/framework/runtime to use contextual logging #116842

Merged
merged 2 commits into from
May 11, 2023
Merged

Migrated pkg/scheduler/framework/runtime to use contextual logging #116842

merged 2 commits into from
May 11, 2023

Conversation

mengjiao-liu
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Migrated pkg/scheduler/framework/runtime to use contextual logging

Which issue(s) this PR fixes:

Part of #91633 (comment)

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Migrated `pkg/scheduler/framework/runtime` to use [contextual logging](https://k8s.io/docs/concepts/cluster-administration/system-logs/#contextual-logging).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-instrumentation/3077-contextual-logging

/sig instrumentation
/wg structured-logging
/area logging
/sig scheduling

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2023
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu mentioned this pull request Mar 22, 2023
Open
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-runtime branch from c727f1d to 220d8ca Compare March 23, 2023 03:55
@mengjiao-liu
Copy link
Member Author

/test all

1 similar comment
@mengjiao-liu
Copy link
Member Author

/test all

@mengjiao-liu mengjiao-liu mentioned this pull request Mar 23, 2023
Merged
@mengjiao-liu
Copy link
Member Author

/test pull-kubernetes-node-e2e-containerd

This was referenced Mar 23, 2023
Merged
Merged
Closed
Merged
@mengjiao-liu mengjiao-liu marked this pull request as ready for review March 23, 2023 09:10
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 23, 2023
@logicalhan
Copy link
Member

/triage accepted
/assign @pohly

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2023
@mengjiao-liu
Copy link
Member Author

PR needs rebase.

Rebased.

@alculquicondor
Copy link
Member

@kerthcet lgtm?

kerthcet
kerthcet reviewed Apr 12, 2023
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow response, I'm not lazy on this but have something to focus on. I will commit to the review work of other PRs as long as I have time. But maybe I should take more advantages of the gap time.

pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-runtime branch from 2774b72 to bb6b58d Compare April 13, 2023 09:28
kerthcet
kerthcet reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General LGTM, except the discussion about https://github.com/kubernetes/kubernetes/pull/116842/files#r1166613985.

pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
alculquicondor
alculquicondor reviewed Apr 27, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should include the changes in schedule_one.go in this PR

Otherwise we might be repeating the pod key over and over.

pkg/scheduler/framework/interface.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Show resolved Hide resolved
pkg/scheduler/framework/runtime/framework.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-runtime branch from bb6b58d to 86b4e3e Compare May 10, 2023 07:45
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 10, 2023
@mengjiao-liu mengjiao-liu force-pushed the contextual-logging-scheduler-runtime branch from 86b4e3e to fe72899 Compare May 11, 2023 07:46
@alculquicondor
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5ec8d133b13954f5f0301ac2300383fe92cb466

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@alculquicondor alculquicondor mentioned this pull request May 11, 2023
Merged
@k8s-ci-robot k8s-ci-robot merged commit 58e1349 into kubernetes:master May 11, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 11, 2023
@mengjiao-liu mengjiao-liu mentioned this pull request May 15, 2023
Merged
@alculquicondor
Copy link
Member

/remove-kind feature
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/feature Categorizes issue or PR as related to a new feature. labels May 16, 2023
@kerthcet kerthcet mentioned this pull request May 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@knelasevero knelasevero knelasevero left review comments

@kerthcet kerthcet kerthcet left review comments

@chendave chendave Awaiting requested review from chendave

@denkensk denkensk Awaiting requested review from denkensk

@pohly pohly Awaiting requested review from pohly

Assignees

@pohly pohly

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/logging cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/structured-logging Categorizes an issue or PR as relevant to WG Structured Logging.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengjiao-liu @k8s-ci-robot @logicalhan @alculquicondor @pohly @knelasevero @kerthcet