-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to released version of v3.8.0 - github.com/emicklei/go-restful/v3 #110518
Switch to released version of v3.8.0 - github.com/emicklei/go-restful/v3 #110518
Conversation
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this has a CVE associated emicklei/go-restful#489 should we backport it? |
we don't use the impacted feature, so I would not expect to backport the bump |
yup |
@liggitt @aojea if I am not mistaken, the apiserver has a filter with its own CORS implementation and looks like it has similar CVE implication. kubernetes/staging/src/k8s.io/apiserver/pkg/server/filters/cors.go Lines 44 to 49 in 8ddbd89
If We enable the CORS filter if the cluster operator specifies
I have added a test and was able to break the CORS policy: I added the following test which should be rejected
But instead, I saw the test fail with the following error:
I have a WIP PR #112809 that adds the new test cases and also has a potential fix. |
It seems this was already reported by @tallclair #71669 (comment)
|
/kind bug
Signed-off-by: Davanum Srinivas davanum@gmail.com
What type of PR is this?
Switch to released tag of v3.8.0 of github.com/emicklei/go-restful/v3, here are the differences:
emicklei/go-restful@7c971ca...v3.8.0
Filed a PR in
kube-openapi
as well here:kubernetes/kube-openapi#304
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: