Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the version of emicklei/go-restful #12730

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Bump the version of emicklei/go-restful #12730

merged 1 commit into from
Jul 13, 2022

Conversation

L3n41c
Copy link
Member

@L3n41c L3n41c commented Jul 12, 2022

What does this PR do?

Bump the version of emicklei/go-restful to 2.16.0 to get the backport emicklei/go-restful#503 of the fix emicklei/go-restful#493 for the vulnerability emicklei/go-restful#489.

Motivation

Fix DataDog/image-vuln-scans#504.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

This has absolutely no impact as the datadog agent doesn’t depend on emicklei/go-restful directly. It’s an indirect dependency of Kubernetes and Kubernetes is not using the feature impacted by the vulnerability.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the config template has been updated.

@L3n41c L3n41c added team/containers changelog/no-changelog [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card dependencies-go PRs that bump a go dependency labels Jul 12, 2022
@L3n41c L3n41c added this to the 7.39.0 milestone Jul 12, 2022
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@L3n41c L3n41c merged commit 4ebcf31 into main Jul 13, 2022
@L3n41c L3n41c deleted the lenaic/bump_go-restful branch July 13, 2022 06:15
L3n41c added a commit that referenced this pull request Jul 13, 2022
ahmed-mez added a commit that referenced this pull request Jul 13, 2022
Co-authored-by: Lénaïc Huard <L3n41c@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog dependencies-go PRs that bump a go dependency [deprecated] qa/skip-qa - use other qa/ labels [DEPRECATED] Please use qa/done or qa/no-code-change to skip creating a QA card team/containers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants