New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent requirement for kind in strict json decoding #109019
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR may require API review. If so, when the changes are ready, complete the pre-review checklist and request an API review. Status of requested reviews is tracked in the API Review project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
staging/src/k8s.io/apimachinery/pkg/runtime/serializer/json/json_test.go
Show resolved
Hide resolved
/lgtm |
/lgtm % tests that are now failing because of missing apiVersion |
/hold hmmm, will dig on those. I verified kind and apiVersion were required when making custom resource requests, but will look at these other uses. |
/hold cancel the implications of adding the apiVersion requirement to existing decoding paths are bigger than we should tackle here. made strict consistent with non-strict for now, and opened #109023 to track |
staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured/helpers.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
/lgtm
/lgtm thanks! |
/retest |
/triage accepted |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When using non-strict unstructured json decoding, kind and apiVersion are required.
When using strict unstructured json decoding, missing kind and apiVersion were tolerated. This adds tests and makes strict decoding consistent.
/cc @apelisse @kevindelgado
/sig api-machinery