Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent requirement for kind in strict json decoding #109019

Merged
merged 2 commits into from Mar 25, 2022

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 25, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

When using non-strict unstructured json decoding, kind and apiVersion are required.

When using strict unstructured json decoding, missing kind and apiVersion were tolerated. This adds tests and makes strict decoding consistent.

Custom resource requests with fieldValidation=Strict consistently require apiVersion and kind, matching non-strict requests

/cc @apelisse @kevindelgado
/sig api-machinery

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Mar 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@apelisse
Copy link
Member

/lgtm
I don't think we'll want to do something about my nit, but in case:
/hold

@kevindelgado
Copy link
Contributor

/lgtm % tests that are now failing because of missing apiVersion

@liggitt
Copy link
Member Author

liggitt commented Mar 25, 2022

/hold

hmmm, will dig on those. I verified kind and apiVersion were required when making custom resource requests, but will look at these other uses.

@liggitt
Copy link
Member Author

liggitt commented Mar 25, 2022

/hold cancel

the implications of adding the apiVersion requirement to existing decoding paths are bigger than we should tackle here. made strict consistent with non-strict for now, and opened #109023 to track

Copy link
Member

@apelisse apelisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 25, 2022
@kevindelgado
Copy link
Contributor

/lgtm thanks!

@liggitt liggitt changed the title Fix inconsistent requirement for apiVersion/kind in strict json decoding Fix inconsistent requirement for kind in strict json decoding Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot removed the release-note-none Denotes a PR that doesn't merit a release note. label Mar 25, 2022
@liggitt
Copy link
Member Author

liggitt commented Mar 25, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 58847ef into kubernetes:master Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Mar 25, 2022
@cici37
Copy link
Contributor

cici37 commented Mar 29, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 29, 2022
@liggitt liggitt deleted the null-fix branch May 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants