Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServerSideFieldValidation Beta Graduation #108889

Merged
merged 2 commits into from Mar 28, 2022
Merged

ServerSideFieldValidation Beta Graduation #108889

merged 2 commits into from Mar 28, 2022

Conversation

kevindelgado
Copy link
Contributor

@kevindelgado kevindelgado commented Mar 22, 2022 •
edited by liggitt

What type of PR is this?

/kind feature

What this PR does / why we need it:

Sets the ServerSideFieldValidation feature gate to beta and on by default and adjusts tests accordingly

Follow up to #108350

Does this PR introduce a user-facing change?

The `ServerSideFieldValidation` feature has graduated to beta and is now enabled by default. Kubectl 1.24 and newer will use server-side validation instead of client-side validation when writing to API servers with the feature enabled.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/2885

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 22, 2022
@k8s-ci-robot k8s-ci-robot added area/apiserver area/kubectl area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 22, 2022
@fedebongio
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 22, 2022
@kevindelgado kevindelgado force-pushed the validation-beta-flag branch 5 times, most recently from 0c1ba59 to c85fd42 Compare March 24, 2022 08:09
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 24, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2022
@liggitt
Copy link
Member

liggitt commented Mar 26, 2022

#108350 is merged, once rebased only the last two commits will remain

feature gate, test description change and addition lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2022
@liggitt liggitt added this to the v1.24 milestone Mar 26, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 28, 2022
@dims
Copy link
Member

dims commented Mar 28, 2022

/retest

/assign @smarterclayton @johnbelamaric

(for conformance test data owners approval)

@liggitt
Copy link
Member

liggitt commented Mar 28, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2022
@liggitt liggitt added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 28, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 28, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, kevindelgado, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2022
@sftim
Copy link
Contributor

sftim commented Mar 28, 2022

For a change log entry, we usually write the entries in the past tense.
So I suggest

Graduated the feature ServerSideFieldValidation to beta and set it to be enabled by default.

@liggitt
Copy link
Member

liggitt commented Mar 28, 2022

updated the release note and noted the implications for kubectl 1.24+ behavior

@kevindelgado kevindelgado mentioned this pull request Mar 28, 2022
Closed
26 tasks
@kevindelgado
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ea0dc6e into kubernetes:master Mar 28, 2022
@tengqm tengqm mentioned this pull request Mar 29, 2022
Closed
@github-actions github-actions bot mentioned this pull request Mar 29, 2022
Open
@sbueringer sbueringer mentioned this pull request May 30, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@apelisse apelisse Awaiting requested review from apelisse

@brianpursley brianpursley Awaiting requested review from brianpursley

Assignees

@liggitt liggitt

@smarterclayton smarterclayton

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/conformance Issues or PRs related to kubernetes conformance tests area/kubectl area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@kevindelgado @fedebongio @liggitt @dims @k8s-triage-robot @johnbelamaric @k8s-ci-robot @sftim @smarterclayton