storage capacity GA #108445

pohly · 2022-03-02T09:06:05Z

What type of PR is this?

/kind feature
/kind api-change

What this PR does / why we need it:

Storage capacity tracking is ready for promotion to GA.

Which issue(s) this PR fixes:

Related-to: kubernetes/enhancements#1472

Special notes for your reviewer:

Does this PR introduce a user-facing change?

CSIStorageCapacity.storage.k8s.io: The v1beta1 version of this API is deprecated in favor of v1, and will be removed in v1.27. If a CSI driver supports storage capacity tracking, then it must get deployed with a release of external-provisioner that supports the v1 API.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/issues/1472
- [Usage]: https://kubernetes.io/docs/concepts/storage/storage-capacity/
- [Other doc]: https://kubernetes-csi.github.io/docs/storage-capacity-tracking.html

pohly · 2022-03-02T09:09:52Z

I know already that one test is failing:

$ PATH=`pwd`/third_party/etcd:$PATH go test ./test/integration/etcd
...
    --- FAIL: TestEtcdStoragePath/storage.k8s.io/v1,_Resource=csistoragecapacities (0.01s)
        etcd_storage_path_test.go:189: Previous releases understand non-alpha versions ["v1beta1"], but do not understand the expected current storage version "v1". This means a current server will store data in etcd that is not understood by a previous version.
        etcd_storage_path_test.go:198: GVK for CSIStorageCapacity does not match, expected storage.k8s.io/v1, Kind=CSIStorageCapacity got storage.k8s.io/v1beta1, Kind=CSIStorageCapacity
FAIL

My understanding was that the version override in

kubernetes/pkg/kubeapiserver/default_storage_factory_builder.go

Line 64 in ab69524

apisstorage.Resource("csistoragecapacities").WithVersion("v1beta1"),

will continue to select v1beta1 as storage version (intentionally left in place in this PR), but I am not sure.

test/integration/etcd/data.go

pkg/kubeapiserver/default_storage_factory_builder.go

hh · 2022-03-22T02:19:05Z

test/e2e/storage/csistoragecapacity.go

+		The csistoragecapacities resource MUST exist in the /apis/storage.k8s.io/v1 discovery document.
+		The csistoragecapacities resource must support create, get, list, watch, update, patch, delete, and deletecollection.
+	*/
+	framework.ConformanceIt(" should support CSIStorageCapacities API operations", func() {


Ideally this test is submitted without 'ConformanceIt' for a couple weeks, then when it's shown stable, we add ConformanceIt(), updated the conformance/testdata. Is that possible?

Sure. I've changed this test so that it gets added as a normal test.

#108867 has the promotion to conformance.

For example, the test runs in pull-kubernetes-e2e-kind and should be in any of the periodic storage tests:

[It] should support CSIStorageCapacities API operations test/e2e/storage/csistoragecapacity.go:48 �[1mSTEP�[0m: getting /apis �[1mSTEP�[0m: getting /apis/storage.k8s.io �[1mSTEP�[0m: getting /apis/storage.k8s.io/v1 �[1mSTEP�[0m: creating �[1mSTEP�[0m: watching Mar 22 07:53:29.629: INFO: starting watch �[1mSTEP�[0m: getting �[1mSTEP�[0m: listing in namespace �[1mSTEP�[0m: listing across namespaces �[1mSTEP�[0m: patching �[1mSTEP�[0m: updating Mar 22 07:53:29.736: INFO: waiting for watch events with expected annotations in namespace Mar 22 07:53:29.736: INFO: waiting for watch events with expected annotations across namespace �[1mSTEP�[0m: deleting �[1mSTEP�[0m: deleting a collection [AfterEach] [sig-storage] CSIStorageCapacity test/e2e/framework/framework.go:186 Mar 22 07:53:29.832: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready �[1mSTEP�[0m: Destroying namespace "csistoragecapacity-5900" for this suite. �[32m•�[0m �[90m------------------------------�[0m {"msg":"PASSED [sig-storage] CSIStorageCapacity should support CSIStorageCapacities API operations","total":-1,"completed":30,"skipped":286,"failed":0}

This is needed for GA APIs. This one is based on test/e2e/common/node/runtimeclass.go.

xing-yang · 2022-03-22T19:35:38Z

/retest

xing-yang · 2022-03-22T19:38:15Z

/lgtm
/approve

k8s-ci-robot · 2022-03-22T19:39:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, msau42, pohly, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [liggitt]
~~pkg/apis/storage/OWNERS~~ [liggitt]
~~pkg/controlplane/storageversionhashdata/OWNERS~~ [liggitt]
~~pkg/features/OWNERS~~ [liggitt,msau42,xing-yang]
~~pkg/generated/openapi/OWNERS~~ [liggitt]
~~pkg/kubeapiserver/OWNERS~~ [liggitt]
~~pkg/printers/OWNERS~~ [liggitt]
~~pkg/registry/OWNERS~~ [liggitt]
~~pkg/scheduler/OWNERS~~ [alculquicondor,liggitt]
~~plugin/pkg/auth/authorizer/OWNERS~~ [liggitt]
~~staging/src/k8s.io/api/OWNERS~~ [liggitt]
~~staging/src/k8s.io/client-go/OWNERS~~ [liggitt]
~~test/OWNERS~~ [liggitt,msau42]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pohly · 2022-03-22T20:07:50Z

/hold cancel

pohly · 2022-03-22T22:08:16Z

/retest

pohly · 2022-03-22T22:22:44Z

/retest

k8s-triage-robot · 2022-03-23T02:29:17Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

hh · 2022-03-23T03:33:35Z

test/e2e/storage/csistoragecapacity.go

+		The csistoragecapacities resource must support create, get, list, watch, update, patch, delete, and deletecollection.
+		TODO (pohly): promote to framework.ConformanceIt
+	*/
+	ginkgo.It(" should support CSIStorageCapacities API operations", func() {


After a couple weeks of non-flaky soaking, we can merge in the conformance promotion PR https://github.com/kubernetes/kubernetes/pull/108867/files#diff-5e1072eb7b333bc3faf7068eb5ce93d29adaad658b5bcdd52a8238c18c5f8f92R47

k8s-triage-robot · 2022-03-23T06:09:17Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

k8s-triage-robot · 2022-03-23T11:15:09Z

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

The PR does have any do-not-merge/* labels
The PR does not have the needs-ok-to-test label
The PR is mergeable (does not have a needs-rebase label)
The PR is approved (has cncf-cla: yes, lgtm, approved labels)
The PR is failing tests required for merge

You can:

Review the full test history for this PR
Prevent this bot from retesting with /lgtm cancel or /hold
Help make our tests less flaky by following our Flaky Tests Guide

/retest

pohly · 2022-03-23T13:22:25Z

/retest

Riaankl · 2022-03-24T19:39:38Z

Testgrid looking good!

Riaankl · 2022-03-28T18:53:21Z

@pohly the test grid for the test have been green every time I checked. 😄
Test freeze is on 6 April. Can you please create the Promtion PR before then to be sure no "new conformance tech debt" will appear for this release.

pohly · 2022-03-28T19:01:51Z

Yes, will do.

k8s-ci-robot requested review from aojea and cheftako March 2, 2022 09:06

pohly force-pushed the storage-capacity-ga branch 2 times, most recently from dbeecff to bcdc134 Compare March 2, 2022 12:22

This was referenced Mar 2, 2022

Mark storage capacity as GA + related updates kubernetes/website#32008

Merged

Storage Capacity Tracking kubernetes/enhancements#1472

Closed

liggitt reviewed Mar 2, 2022

View reviewed changes

test/integration/etcd/data.go Show resolved Hide resolved

liggitt reviewed Mar 2, 2022

View reviewed changes

pkg/kubeapiserver/default_storage_factory_builder.go Outdated Show resolved Hide resolved

liggitt self-assigned this Mar 2, 2022

liggitt added this to Assigned in API Reviews Mar 2, 2022

pohly mentioned this pull request Mar 2, 2022

storage capacity tracking: switch storage version from v1beta1 to v1 #108451

Closed

hh reviewed Mar 22, 2022

View reviewed changes

pohly force-pushed the storage-capacity-ga branch from 51cb185 to 39a5cff Compare March 22, 2022 07:10

storage capacity: CRUD conformance test

f5340fd

This is needed for GA APIs. This one is based on test/e2e/common/node/runtimeclass.go.

pohly force-pushed the storage-capacity-ga branch from 39a5cff to f5340fd Compare March 22, 2022 07:13

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2022

pohly mentioned this pull request Mar 22, 2022

storage capacity conformance #108867

Merged

k8s-ci-robot assigned xing-yang Mar 22, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2022

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2022

hh reviewed Mar 23, 2022

View reviewed changes

xing-yang mentioned this pull request Mar 23, 2022

Handle Non-graceful Node Shutdown #108486

Merged

k8s-ci-robot merged commit 24a7199 into kubernetes:master Mar 23, 2022

SIG Auth Old automation moved this from Needs Triage to Closed / Done Mar 23, 2022

k8s-ci-robot added this to the v1.24 milestone Mar 23, 2022

github-actions bot mentioned this pull request Mar 29, 2022

Week Ending March 27, 2022 dev-obs/actus#407

Open

tkashem mentioned this pull request May 2, 2022

[rebase 1.24] disable tests with time limit to facilitate rebase openshift/origin#27086

Merged

Jefftree mentioned this pull request Nov 30, 2022

Omit list_type_missing lint error from *List types kubernetes/kube-openapi#281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage capacity GA #108445

storage capacity GA #108445

pohly commented Mar 2, 2022

pohly commented Mar 2, 2022

hh Mar 22, 2022

pohly Mar 22, 2022

pohly Mar 22, 2022

xing-yang commented Mar 22, 2022

xing-yang commented Mar 22, 2022

k8s-ci-robot commented Mar 22, 2022

pohly commented Mar 22, 2022

pohly commented Mar 22, 2022

pohly commented Mar 22, 2022

k8s-triage-robot commented Mar 23, 2022

hh Mar 23, 2022

k8s-triage-robot commented Mar 23, 2022

k8s-triage-robot commented Mar 23, 2022

pohly commented Mar 23, 2022

Riaankl commented Mar 24, 2022

Riaankl commented Mar 28, 2022

pohly commented Mar 28, 2022

storage capacity GA #108445

storage capacity GA #108445

Conversation

pohly commented Mar 2, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

pohly commented Mar 2, 2022

hh Mar 22, 2022

Choose a reason for hiding this comment

pohly Mar 22, 2022

Choose a reason for hiding this comment

pohly Mar 22, 2022

Choose a reason for hiding this comment

xing-yang commented Mar 22, 2022

xing-yang commented Mar 22, 2022

k8s-ci-robot commented Mar 22, 2022

pohly commented Mar 22, 2022

pohly commented Mar 22, 2022

pohly commented Mar 22, 2022

k8s-triage-robot commented Mar 23, 2022

hh Mar 23, 2022

Choose a reason for hiding this comment

k8s-triage-robot commented Mar 23, 2022

k8s-triage-robot commented Mar 23, 2022

pohly commented Mar 23, 2022

Riaankl commented Mar 24, 2022

Riaankl commented Mar 28, 2022

pohly commented Mar 28, 2022