[rebase 1.24] disable tests with time limit to facilitate rebase #27086
Conversation
|
/assign @deads2k @p0lyn0mial |
|
/lgtm this is what we did in the past to facilitate rebases |
|
/hold let's get a "why" for each one please. |
openshift-ci
bot
added
the
do-not-merge/hold
We're working on getting better over time. |
test/extended/util/annotate/rules.go
Outdated
|
|
||
| // TODO: to facilitate v.14 rebase, must be removed after the rebase PR lands | ||
| `\[sig-auth\] ServiceAccounts should allow opting out of API token automount`, | ||
| `\[sig-instrumentation\] Events API should ensure that an event can be fetched, patched, deleted, and listed`, |
There was a problem hiding this comment.
Breaking an API contract like this appears suspicious, why exclude it.
There was a problem hiding this comment.
See bug https://bugzilla.redhat.com/show_bug.cgi?id=2081084, to make sure we don't ship without fixing this.
I think we see this test failing because origin/test (from previous version v1.23) is running against an apiserver (v1.24 with rebase PR)
So hopefully, when re re-vendor v1.24 into openshift/origin it should resolve, otherwise we will need to fix it before we ship 4.11.0
There was a problem hiding this comment.
Please locate the fix and ideally fix it here. We have previously created blocker+ bugs, which were later deferred. Let's do better.
There was a problem hiding this comment.
this relates to kubernetes/kubernetes#108047. so the old test in openshift/origin is running against a new apiserver.
test/extended/util/annotate/rules.go
Outdated
| @@ -66,6 +66,11 @@ var ( | |||
|
|
|||
| // https://bugzilla.redhat.com/show_bug.cgi?id=2004074 | |||
| `\[sig-network-edge\]\[Feature:Idling\] Unidling should work with TCP \(while idling\)`, | |||
|
|
|||
| // TODO: to facilitate v.14 rebase, must be removed after the rebase PR lands | |||
| `\[sig-auth\] ServiceAccounts should allow opting out of API token automount`, | |||
There was a problem hiding this comment.
This doesn't look proper either. do we need an early pick?
There was a problem hiding this comment.
See bug https://bugzilla.redhat.com/show_bug.cgi?id=2081087, to make sure we don't ship without fixing this.
I think we see this test failing because origin/test (from previous version v1.23) is running against an apiserver (v1.24 with rebase PR)
So hopefully, when re re-vendor v1.24 into openshift/origin it should resolve, otherwise we will need to fix it before we ship 4.11.0
There was a problem hiding this comment.
Please locate the fix and ideally fix it here. We have previously created blocker+ bugs, which were later deferred. Let's do better.
There was a problem hiding this comment.
relates to upstream pr: kubernetes/kubernetes#108309
test/extended/util/annotate/rules.go
Outdated
| // - [sig-auth\] ServiceAccounts : https//bugzilla.redhat.com/show_bug.cgi?id=2081087 | ||
| `\[sig-auth\] ServiceAccounts should allow opting out of API token automount`, | ||
| `\[sig-instrumentation\] Events API should ensure that an event can be fetched, patched, deleted, and listed`, | ||
| `\[sig-api-machinery\] API data in etcd should be stored at the correct location and version for all resources`, |
There was a problem hiding this comment.
find a way to skip this for 3 three weeks and have it auto-come back. This being a variable, seems like a clever init block could do it. This one I can accept will fail until the new level is merged.
There was a problem hiding this comment.
and the etcd data location relates to kubernetes/kubernetes#108445. v1 of csistoragecapacities has been added to 1.24.
|
I think all three test failures will resolve once we vendor o/k into origin after the rebase PR lands, see the related upstream PRs:
|
openshift-ci
bot
added
the
needs-rebase
openshift-ci
bot
removed
the
needs-rebase
|
/assign @soltysh |
tkashem
changed the title
|
/retest |
cmd/openshift-tests/e2e.go
Outdated
| // if the specified date in the tag has not passed yet, the test | ||
| // will be skipped by the runner. | ||
| func shouldSkipUntil(name string) bool { | ||
| _, after, found := cut(name, "[SkippedUntil:") |
There was a problem hiding this comment.
How about using something like:
re, err := regexp.Compile(`\[SkippedUntil:(\d{6})\]`)
s := re.FindStringSubmatch(name)
this will return you 2-element array, where the first is the entire [SkippedUntil:123456] and the 2nd will be just 123456.
There was a problem hiding this comment.
SkippedUntil:<Date>,blocker-bz/<number> to make the requirement clear.
test/extended/util/annotate/rules.go
Outdated
| // - [sig-api-machinery] API data in etcd should be: https://bugzilla.redhat.com/show_bug.cgi?id=2081021 | ||
| // - [sig-instrumentation] Events API should ensure that: https://bugzilla.redhat.com/show_bug.cgi?id=2081084 | ||
| // - [sig-auth] ServiceAccounts : https//bugzilla.redhat.com/show_bug.cgi?id=2081087 | ||
| "[SkippedUntil:05272022]": { |
There was a problem hiding this comment.
since we check it in isDisabled we could rename to [DisabledUntil...]
There was a problem hiding this comment.
so we use both Disabled and Skipped - i don't know what the semantic differences are between these two. Also i want to avoid a DisabledUntil: tag get misinterpreted as plain Disabled
func isDisabled(name string) bool {
return strings.Contains(name, "[Disabled")
}
|
/retest-required |
5 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@tkashem: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-ovn-ipv6 |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
10 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
No description provided.