Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graduate PodAffinityNamespaceSelector to GA #108136

Merged
merged 1 commit into from Feb 19, 2022
Merged

Graduate PodAffinityNamespaceSelector to GA #108136

merged 1 commit into from Feb 19, 2022
+136 −589

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Feb 15, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Graduates PodAffinityNamespaceSelector to GA

Which issue(s) this PR fixes:

Part of kubernetes/enhancements#2249

Special notes for your reviewer:

Does this PR introduce a user-facing change?

pod-affinity namespace selector and cross-namespace quota graduated to GA. The feature gate PodAffinityNamespaceSelector is locked and will be removed in 1.26.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/2249-pod-affinity-namespace-selector

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 15, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@ahg-g ahg-g mentioned this pull request Feb 15, 2022
Closed
12 tasks
@fedebongio
Copy link
Contributor

/assign @kubernetes/api-reviewers
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 15, 2022
@liggitt liggitt added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 15, 2022
@liggitt liggitt added this to the v1.24 milestone Feb 15, 2022
@liggitt liggitt self-assigned this Feb 15, 2022
@liggitt liggitt added this to Assigned in API Reviews Feb 15, 2022
@kerthcet
Copy link
Member

looks good to me generally.

@liggitt liggitt moved this from Assigned to In progress in API Reviews Feb 17, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2022

Also update the release note mentions that the feature gate is locked and will be removed in 1.26

Done, commit squashed as well

@liggitt
Copy link
Member

liggitt commented Feb 17, 2022

/approve
for API changes

@liggitt liggitt moved this from In progress to API review completed, 1.24 in API Reviews Feb 17, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2022

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Feb 17, 2022

/assign @alculquicondor

for scheduler lgtm

alculquicondor
alculquicondor reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@liggitt
Copy link
Member

liggitt commented Feb 18, 2022

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kerthcet
Copy link
Member

kerthcet commented Feb 18, 2022 •
edited

Should we squash the commit @ahg-g ?

@alculquicondor
Copy link
Member

/hold
for squash

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 18, 2022
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Feb 18, 2022

/retest

@ahg-g
Copy link
Member Author

ahg-g commented Feb 19, 2022

/hold cancel

can I get another lgtm pls

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2022
@kerthcet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit d5263fe into kubernetes:master Feb 19, 2022
@tengqm tengqm mentioned this pull request Mar 18, 2022
Closed
@reylejano reylejano mentioned this pull request Mar 23, 2022
Merged
@SataQiu SataQiu mentioned this pull request Sep 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@kerthcet kerthcet kerthcet left review comments

@damemi damemi Awaiting requested review from damemi

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@alculquicondor alculquicondor

@kerthcet kerthcet

@msau42 msau42

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.24
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahg-g @k8s-triage-robot @fedebongio @kerthcet @msau42 @liggitt @k8s-ci-robot @alculquicondor