Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pod affinity namespaceSelector to GA #32352

Merged
merged 1 commit into from Mar 23, 2022
Merged

Pod affinity namespaceSelector to GA #32352

merged 1 commit into from Mar 23, 2022

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Mar 18, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2022
@netlify
Copy link

netlify bot commented Mar 18, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: ec2133b

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62349ef83765ef000834c47b

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 18, 2022
@ahg-g
Copy link
Member Author

ahg-g commented Mar 18, 2022

/assign @alculquicondor

@ahg-g ahg-g mentioned this pull request Mar 18, 2022
Closed
12 tasks
alculquicondor
alculquicondor reviewed Mar 18, 2022
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 18, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e7f5196e53fb18e7c45d593950d5098e3ab8de88

@tengqm
Copy link
Contributor

tengqm commented Mar 19, 2022

/lgtm
I'm abandoning my change #32332

@mehabhalodiya
Copy link
Contributor

/assign @PI-Victor

@sftim
Copy link
Contributor

sftim commented Mar 21, 2022

LGTM

1 similar comment
@sftim
Copy link
Contributor

sftim commented Mar 21, 2022

LGTM

@reylejano
Copy link
Member

Code has merged in kubernetes/kubernetes#108136

LGTM from SIG Scheduling tech lead and SIG Docs tech leads

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2022
@k8s-ci-robot k8s-ci-robot merged commit bfca388 into kubernetes:dev-1.24 Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@davidopp davidopp Awaiting requested review from davidopp

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@alculquicondor alculquicondor

@tengqm tengqm

@PI-Victor PI-Victor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ahg-g @k8s-ci-robot @tengqm @mehabhalodiya @sftim @reylejano @alculquicondor @PI-Victor