New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graduate NonPreemptingPriority to GA #107432
Graduate NonPreemptingPriority to GA #107432
Conversation
@denkensk: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
44a31e6
to
e70093d
Compare
e70093d
to
1aa19e5
Compare
/hold |
/unhold |
/lgtm Thanks! |
/assign @liggitt |
API changes lgtm. Have the stable criteria (https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/902-non-preempting-priorityclass#stable-v124) been completed? |
Yes @liggitt |
9158341
to
5419073
Compare
squash the commits |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Leaving approval to Wei or Aldo.
it's already approved. We need API approval |
There is a new commit after Wei gave his LGTM. So I thought you or Wei need to have a look at it again. |
Thanks @ravisantoshgudimetla |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: denkensk, Huang-Wei, liggitt, ravisantoshgudimetla The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/sig scheduling
What this PR does / why we need it:
Which issue(s) this PR fixes:
Ref kubernetes/enhancements#902
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: