Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate NonPreemptingPriority to GA #107432

Conversation

denkensk
Copy link
Member

@denkensk denkensk commented Jan 9, 2022

What type of PR is this?

/kind feature
/sig scheduling

What this PR does / why we need it:

Which issue(s) this PR fixes:

Ref kubernetes/enhancements#902

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Feature of `NonPreemptingPriority` is graduated  to GA

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/902-non-preempting-priorityclass

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jan 9, 2022
@k8s-ci-robot
Copy link
Contributor

@denkensk: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 9, 2022
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 10, 2022
@denkensk denkensk force-pushed the graduate-nonpreemptingpriority-to-ga branch 2 times, most recently from 44a31e6 to e70093d Compare January 10, 2022 13:04
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 10, 2022
@denkensk denkensk force-pushed the graduate-nonpreemptingpriority-to-ga branch from e70093d to 1aa19e5 Compare January 10, 2022 15:49
@denkensk denkensk changed the title [WIP] Graduate NonPreemptingPriority to GA Graduate NonPreemptingPriority to GA Jan 10, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2022
@denkensk
Copy link
Member Author

/cc @ahg-g @Huang-Wei @alculquicondor

@alculquicondor
Copy link
Member

/hold
for kubernetes/enhancements#3110

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2022
@denkensk
Copy link
Member Author

denkensk commented Feb 1, 2022

/hold

for #107775

/unhold
@Huang-Wei please review again

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2022
@Huang-Wei
Copy link
Member

/lgtm
/approve

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2022
@denkensk
Copy link
Member Author

denkensk commented Feb 1, 2022

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 8, 2022

@liggitt liggitt added this to API review completed, 1.24 in API Reviews Feb 8, 2022
@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

@denkensk denkensk force-pushed the graduate-nonpreemptingpriority-to-ga branch from 9158341 to 5419073 Compare February 8, 2022 10:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

squash the commits

@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

/retest

Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Leaving approval to Wei or Aldo.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@alculquicondor
Copy link
Member

it's already approved. We need API approval

@ravisantoshgudimetla
Copy link
Contributor

There is a new commit after Wei gave his LGTM. So I thought you or Wei need to have a look at it again.

@denkensk
Copy link
Member Author

denkensk commented Feb 8, 2022

There is a new commit after Wei gave his LGTM. So I thought you or Wei need to have a look at it again.

Thanks @ravisantoshgudimetla
no updates. just squash the commits.

@liggitt
Copy link
Member

liggitt commented Feb 8, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: denkensk, Huang-Wei, liggitt, ravisantoshgudimetla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 24e5d1f into kubernetes:master Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 8, 2022
@denkensk denkensk deleted the graduate-nonpreemptingpriority-to-ga branch February 12, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: API review completed, 1.24
Development

Successfully merging this pull request may close these issues.

None yet

8 participants