Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong capitalization for preemptionPolicy field #31262

Closed
sftim opened this issue Jan 9, 2022 · 6 comments · Fixed by #31267
Closed

Wrong capitalization for preemptionPolicy field #31262

sftim opened this issue Jan 9, 2022 · 6 comments · Fixed by #31267
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sftim
Copy link
Contributor

sftim commented Jan 9, 2022

This is a Bug Report

Problem:
In https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#non-preempting-priority-class, the preemptionPolicy field is written, incorrectly, as PreemptionPolicy (in some places).

Proposed Solution:
Fix the capitalization to camelCase.

/sig scheduling
Relevant as there's a plan to graduate the feature.

Page to Update:
https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/

Additional Information:
/language en
/priority backlog
@sftim sftim added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2022
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2022
@jihoon-seo
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2022
@denkensk
Copy link
Member

/cc

@mengjiao-liu mengjiao-liu mentioned this issue Jan 10, 2022
Merged
@mengjiao-liu
Copy link
Member

/assgin

@denkensk
Copy link
Member

PR for GA list here:
#31283

@sftim
Copy link
Contributor Author

sftim commented Jan 11, 2022

(In my view), #31283 should wait for #31267 to merge.

@denkensk
Copy link
Member

(In my view), #31283 should wait for #31267 to merge.

@sftim Yes, I will add /hold in #31283 to wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong capitalization for preemptionPolicy field mengjiao-liu/website
5 participants
@denkensk @k8s-ci-robot @sftim @mengjiao-liu @jihoon-seo