Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove scheduler component config v1beta1 #104782

Merged
merged 1 commit into from Oct 4, 2021
Merged

remove scheduler component config v1beta1 #104782

merged 1 commit into from Oct 4, 2021

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented Sep 5, 2021 •
edited by k8s-ci-robot

Signed-off-by: kerthcet kerthcet@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

As component config will be evolved to v1beta3 in release1.23, we will remove v1beta1 support as maintaining 3+ apis seems unnecessary.

Which issue(s) this PR fixes:

Fixes #kubernetes/enhancements#2901

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler: support for configuration file version `v1beta1` is removed. Update configuration files to v1beta2(xref: https://github.com/kubernetes/enhancements/issues/2901) or v1beta3 before upgrading to 1.23.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/pull/2921

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 5, 2021
@kerthcet
Copy link
Member Author

kerthcet commented Sep 5, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 5, 2021
@kerthcet kerthcet mentioned this pull request Sep 5, 2021
Closed
8 tasks
@kerthcet
Copy link
Member Author

kerthcet commented Sep 8, 2021

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 24, 2021
@kerthcet
Copy link
Member Author

/retest

1 similar comment
@kerthcet
Copy link
Member Author

/retest

ahg-g
ahg-g reviewed Sep 27, 2021
View reviewed changes
Copy link
Member

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also need to remove the definitions in the staging repo: https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/kube-scheduler/config/v1beta1

pkg/scheduler/apis/config/validation/validation.go Show resolved Hide resolved
test/integration/scheduler/queue_test.go Show resolved Hide resolved
@kerthcet
Copy link
Member Author

/retest

@fedebongio
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 28, 2021
@Huang-Wei Huang-Wei mentioned this pull request Sep 29, 2021
Merged
@damemi damemi mentioned this pull request Sep 29, 2021
Closed
@kerthcet
Copy link
Member Author

kindly ping @Huang-Wei @ahg-g @damemi

@ahg-g
Copy link
Member

ahg-g commented Sep 29, 2021

/label api-review
/lgtm

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Sep 29, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2021
@ahg-g
Copy link
Member

ahg-g commented Sep 29, 2021

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 29, 2021
@Huang-Wei
Copy link
Member

/approve
on scheduling side.

@kerthcet
Copy link
Member Author

kerthcet commented Oct 2, 2021 •
edited

I was wondering whether someone I can ask to help reviewing this PR to prevent blocking another related one.

@ahg-g
Copy link
Member

ahg-g commented Oct 4, 2021

/assign @liggitt

@liggitt liggitt added this to In progress in API Reviews Oct 4, 2021
@liggitt
Copy link
Member

liggitt commented Oct 4, 2021

/approve

please update the release note with a link to the docs for the v1beta1 → v1beta2 (or v1beta3) migration instructions

@liggitt liggitt moved this from In progress to API review completed, 1.23 in API Reviews Oct 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Huang-Wei, kerthcet, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 04f747d into kubernetes:master Oct 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Oct 4, 2021
@alculquicondor alculquicondor mentioned this pull request Oct 12, 2021
Closed
@pacoxu
Copy link
Member

pacoxu commented Nov 3, 2021

/release-note-edit

kube-scheduler: support for configuration file version `v1beta1` is removed. Update configuration files to v1beta2(xref: https://github.com/kubernetes/enhancements/issues/2901) or v1beta3 before upgrading to 1.23.

@daichimukai daichimukai mentioned this pull request Jan 11, 2022
Closed
4 tasks
@kerthcet kerthcet deleted the cleanup/remove-cc-v1beta1 branch June 13, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Huang-Wei Huang-Wei Huang-Wei left review comments

@ahg-g ahg-g ahg-g left review comments

@adtac adtac Awaiting requested review from adtac

Assignees

@liggitt liggitt

@ahg-g ahg-g

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.23
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@kerthcet @k8s-ci-robot @ahg-g @k8s-triage-robot @fedebongio @Huang-Wei @liggitt @pacoxu