Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Policy scheduling config #92143

Closed
alculquicondor opened this issue Jun 15, 2020 · 28 comments · Fixed by #105424
Closed

Deprecate Policy scheduling config #92143

alculquicondor opened this issue Jun 15, 2020 · 28 comments · Fixed by #105424
Assignees
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.

Comments

@alculquicondor
Copy link
Member

/sig scheduling

As we move forward with graduating component config #89701 (targetting beta for 1.19), Policy APIs are redundant and thus can be removed.

Following API guidelines, we should have a GA alternative for 2 releases. Given current projections, we can remove Policy config in 1.23

@damemi
Copy link
Contributor

damemi commented Jul 10, 2020

This will be related to removing algorithmSource from the internal api (#87526), so just commenting to link these two issues so they're easier to find

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 8, 2020
@damemi
Copy link
Contributor

damemi commented Oct 9, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 9, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2021
@alculquicondor
Copy link
Member Author

/remove-lifecycle stale

Promotion of component config to GA hopefully happens in 1.22. In the meantime, we have to keep the policy config.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 7, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2021
@damemi
Copy link
Contributor

damemi commented Apr 7, 2021

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 7, 2021
@ahg-g
Copy link
Member

ahg-g commented Jun 15, 2021

Lets try to set a target release to remove policy config and announce that so that users have enough time to migrate.

Do we feel that CC is mature enough to announce policy config deprecation in 1.23? There are more changes coming to CC, but they are properly versioned and moving from beta2->beta3->GA should not be problematic, and probably better than continuing to depend on policy config.

@alculquicondor
Copy link
Member Author

The policy API is already marked as deprecated. Maybe we can add a log line that says when it's going to be removed.

+1 to removal in 1.23

@ahg-g
Copy link
Member

ahg-g commented Jun 15, 2021

Yeah, adding a log line, updating the website docs and sending an email to sig-scheduling and kubernetes-dev google groups.

@ahg-g
Copy link
Member

ahg-g commented Jun 15, 2021

@damemi would you like to follow up on that? Start with announcing on the mailing lists to bring attention to the proposal before we update the logs and docs.

@damemi
Copy link
Contributor

damemi commented Jun 15, 2021

@ahg-g can do, I'll send out the emails later today

@kerthcet
Copy link
Member

/cc

@ahg-g
Copy link
Member

ahg-g commented Aug 20, 2021

I think we need a KEP to remove this since it will cause doc updates and whatnot.

@kerthcet
Copy link
Member

I'm glad to write the KEP if no one else is working on this. However, since it's my first time to write KEP, I think I will spend more time than familiar ones.

@ahg-g
Copy link
Member

ahg-g commented Aug 23, 2021

sg, @damemi do you want to help @kerthcet through the process?

@damemi
Copy link
Contributor

damemi commented Aug 24, 2021

Sure, @kerthcet the first step is to create an issue in https://github.com/kubernetes/enhancements, and a PR defining your changes following the template provided at https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template (both of these have comments guiding how to fill out each section)

@kerthcet
Copy link
Member

Sure, @kerthcet the first step is to create an issue in https://github.com/kubernetes/enhancements, and a PR defining your changes following the template provided at https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template (both of these have comments guiding how to fill out each section)

thanks @damemi, I'll try my best.🥷

@ahg-g
Copy link
Member

ahg-g commented Aug 30, 2021

Actually, instead of creating a new KEP (which I am not sure what we will put in it on its own), how about we piggyback on the CC KEP and v1beta3 graduation? The idea is to have a KEP that references the deprecation and allows us to update the docs.

@damemi
Copy link
Contributor

damemi commented Aug 30, 2021

Yeah this could be added to the CC deprecation KEP under the section describing v1beta3 https://github.com/kubernetes/enhancements/pull/2850/files#diff-535abc4c1be084f369a0b7a4951db2258d840f1657e331d0c4c6c13d537cc949R100

@kerthcet
Copy link
Member

Actually, instead of creating a new KEP (which I am not sure what we will put in it on its own), how about we piggyback on the CC KEP and v1beta3 graduation? The idea is to have a KEP that references the deprecation and allows us to update the docs.

yes, it's also convinced, since it's part of the lifecycle of a new feature. However, I'll still work on this kep, on the one hand to walk through a completely cycle of kep, on the other hand, if we open our arms again, I think it will play a role.

@kerthcet
Copy link
Member

If reopen the former kep is accepted, I'll keep these two keps in sync. And after I finished, I'll close the new one. maybe I will need a help from @damemi to review my kep and give me some advice.

@ahg-g
Copy link
Member

ahg-g commented Aug 31, 2021

I don't think we need a standalone KEP, you will have other chances to learn the process :)

We also need to mark v1beta1 deprecated as part of v1beta3 graduation. Since we are getting closer to the KEP deadline, @damemi do you want to send an update to the KEP? I can send it too.

@damemi
Copy link
Contributor

damemi commented Aug 31, 2021

I think @kerthcet can update the KEP, I don't want to take that.

@kerthcet what you need to do is open a PR in github.com/kubernetes/enhancements updating keps/sig-scheduling/785-scheduler-component-config-api/README.md to note:

  • Policy config is deprecated
  • v1beta1 is deprecated

These will be under the v1beta3 section I linked to above. Does that sound good? If not, I can do it

@kerthcet
Copy link
Member

kerthcet commented Sep 1, 2021

I don't think we need a standalone KEP, you will have other chances to learn the process :)

We also need to mark v1beta1 deprecated as part of v1beta3 graduation. Since we are getting closer to the KEP deadline, @damemi do you want to send an update to the KEP? I can send it too.

sounds good. I'll close the kep.

@kerthcet
Copy link
Member

kerthcet commented Sep 1, 2021

I think @kerthcet can update the KEP, I don't want to take that.

@kerthcet what you need to do is open a PR in github.com/kubernetes/enhancements updating keps/sig-scheduling/785-scheduler-component-config-api/README.md to note:

  • Policy config is deprecated
  • v1beta1 is deprecated

These will be under the v1beta3 section I linked to above. Does that sound good? If not, I can do it

yeah, I'm glad to, thanks @damemi

@ahg-g
Copy link
Member

ahg-g commented Sep 27, 2021

/assign @damemi

@damemi
Copy link
Contributor

damemi commented Sep 29, 2021

/assign @kerthcet
xref kubernetes/enhancements#2901 and #104782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants