-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use docker buildx for etcd image #104116
Use docker buildx for etcd image #104116
Conversation
So, I can only see this postsubmit which seems to build the images: |
/test pull-kubernetes-integration |
@saschagrunert let's update the REVISION as well ( https://github.com/kubernetes/kubernetes/blob/master/cluster/images/etcd/Makefile#L37 ) |
This allows to choose the correct architecture in the image manifest, which defaulted to the host system before applying this patch. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
Yep, done 👍 |
771c8f0
to
ea1bc18
Compare
/assign @jpbetz @wenjiaswe |
I'm not all that familiar with qemu-user-static, but from what I was able to glean after some reading suggests this should work fine. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jpbetz, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/priority important-longterm |
@pacoxu: GitHub didn't allow me to request PR reviews from the following users: EricWvi. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The postsubmit ci failed to run |
What @pacoxu said, the postsubmit has been breaking ever since this merged |
Last known good:
First bad:
|
What type of PR is this?
/kind bug
What this PR does / why we need it:
This allows to choose the correct architecture in the image manifest,
which defaulted to the host system before applying this patch.
Which issue(s) this PR fixes:
Refers to #104085
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: