New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PersistentVolumeLabel admission plugin #124505
Conversation
/sig storage |
/priority important-soon |
Unknown CLA label state. Rechecking for CLA labels. Send feedback to sig-contributor-experience at kubernetes/community. /check-cla |
/approve |
LGTM label has been added. Git tree hash: 4fbe1bfff8434fcd86b21777462aa3d27d9c83fa
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
Left a comment about deleting the admission plugin instead
@@ -205,18 +203,6 @@ func (l *persistentVolumeLabel) findVolumeLabels(volume *api.PersistentVolume) ( | |||
return nil, fmt.Errorf("error querying GCE PD volume %s: %v", volume.Spec.GCEPersistentDisk.PDName, err) | |||
} | |||
return labels, nil | |||
case volume.Spec.AzureDisk != nil: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this PR and #124519, I suggest just removing the entire admission plugin. It has been deprecated for many releases and we published an external alternative https://github.com/kubernetes-sigs/cloud-pv-admission-labeler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know about https://github.com/kubernetes-sigs/cloud-pv-admission-labeler. I agree that removing the admission is the best way forward now.
60c241a
to
1152526
Compare
need to remove:
|
xref: #52617 |
Remove useless admission plugin. * It has been deprecated for years. * All in-tree cloud providers were removed, so the admission plugin does not have any way to get PV labels. * There is a replacement in https://github.com/kubernetes-sigs/cloud-pv-admission-labeler
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
hack/make-rules/test-cmd.sh updated.
|
/retest |
/approve |
LGTM label has been added. Git tree hash: 5ff7acbdf0542434bf85a774f7890f96b03b81d1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel ( removing hold as we are now cleaning up per @andrewsykim 's comment thanks @jsafrane |
What type of PR is this?
/kind bug
/kind regression
What this PR does / why we need it:
Remove useless admission plugin.
any way to get PV labels.
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: