Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove PersistentVolumeLabel admission plugin #46302

Merged
merged 1 commit into from May 11, 2024
Merged

remove PersistentVolumeLabel admission plugin #46302

merged 1 commit into from May 11, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 10, 2024

kubernetes/kubernetes#124505 removed admission plugin PersistentVolumeLabel.

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels May 10, 2024
@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 8c773b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/663d9748bdb2c900089bd063

@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8c773b2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663d97484bb6b000086ec0e7
😎 Deploy Preview https://deploy-preview-46302--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlory carlory force-pushed the clean-PersistentVolumeLabel branch from a359fb9 to d9da4ce Compare May 10, 2024 03:26
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2024
@carlory carlory force-pushed the clean-PersistentVolumeLabel branch from d9da4ce to 6b89108 Compare May 10, 2024 03:27
@carlory
Copy link
Member Author

carlory commented May 10, 2024

/cc @jsafrane

@carlory carlory changed the title cleanup removed PersistentVolumeLabel admission plugin updatePersistentVolumeLabel admission plugin May 10, 2024
@carlory carlory force-pushed the clean-PersistentVolumeLabel branch from 6b89108 to 8c773b2 Compare May 10, 2024 03:40
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 10, 2024
@carlory carlory changed the title updatePersistentVolumeLabel admission plugin remove PersistentVolumeLabel admission plugin May 10, 2024
@sftim
Copy link
Contributor

sftim commented May 10, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 10, 2024
@jsafrane
Copy link
Member

thanks a lot!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 749ca4805a48f0caa8f968f46c90d4ca88322490

@tengqm
Copy link
Contributor

tengqm commented May 10, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit bbf95cd into kubernetes:dev-1.31 May 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@lavalamp lavalamp Awaiting requested review from lavalamp

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlory @sftim @jsafrane @k8s-ci-robot @tengqm