New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gcp in-tree cloud provider and credential providers #124519
Remove gcp in-tree cloud provider and credential providers #124519
Conversation
/priority important-soon |
/hold didn't know if we are waiting for any other area reviews. feel free to remove hold if not. |
Thanks @elmiko
I have a side note from @seans3 about making progress on moving some of the in-tree e2e tests to cloud-provider-gcp repo. Since we can always look at what we dropped in thanks everyone for the support and reviews! /hold cancel |
Hi @dims After this PR is merged, is it time to remove |
@carlory let's give it some time in case we find something really wrong, am sure there's quite a few things we'll have to go clean up and we'll need your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changelog suggestion (untested for accuracy; this is based on my guesses as to what the current text means) Removed the last remaining in-tree code for integrating with GCP as cloud provider (cloud controller manager),
and code fetching GCP credentials used during container image pulls.
Please use the external cloud provider and credential provider from https://github.com/kubernetes/cloud-provider-gcp instead. ℹ️ It's possible the removed code was for kubectl credential exec plugins instead, I haven't checked. |
Hi! This change broke the autoscaler tests https://testgrid.k8s.io/sig-autoscaling-cluster-autoscaler#gci-gce-autoscaling - I started looking at them just recently (just before they broke as there were some constantly failing ones) and it seems that they might have missed some required migration. Since KEP does not mention any required migration for tests could you have a look and try pointing out what these tests are missing? They are probably missing some switch to external provider, but I am not sure where it should be made. Could you link for example migration of other tests so that I can apply the same logic to these tests? |
This PR switches the provider implement to FYI:
|
e2e tests:
Hi @jbtk, Do those tests must be run on a cluster with GCE, or can be run on a kind cluster? I saw that @pohly is raising a PR #123078. In that PR, it uses kind cluster to run some tests related to cluster autoscaler and DRA. cc @dims should we revert this PR or just skip e2e tests util it can use kind cluster?
|
Learnt from the release notes: we may need to install |
These tests that are cloud provider specific have to be moved to the corresponding cloud-provider repo @jbtk , please reach out to @seans3 and @BenTheElder kubernetes/cloud-provider-gcp#683
@carlory these tests will not work from this repo since this change |
/triage accepted |
Related to KEPs:
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig cloud-provider
/sig auth