Deeply copy JSONSchemaProps.XValidations.

[benluddy]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Mutations to XValidations in a deep-copied CRD's schema can alter the original.

Which issue(s) this PR fixes:

Fixes #107954

Does this PR introduce a user-facing change?

CRD deep copies should no longer contain shallow copies of JSONSchemaProps.XValidations.

[k8s-ci-robot]

Hi @benluddy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[benluddy]

/assign @jpbetz

[benluddy]

/sig api-machinery

[k8s-triage-robot]

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

[benluddy]

/cc @sttts

[aojea]

/ok-to-test

[aojea]

/assign @liggitt
you are going to like this one

[liggitt]

huh... glad to see this fixed... is there a test that should be updated that would have noticed this deterministically in presubmit?

[liggitt]

trying to remember why these are hand-written and not generated

[benluddy]

huh... glad to see this fixed... is there a test that should be updated that would have noticed this deterministically in presubmit?

The fuzzer seeds the global math/rand source from itself in https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apimachinery/pkg/api/apitesting/roundtrip/roundtrip.go#L63, so it probably depends on whatever else is using that source in-process. That should probably be seeded from a better source of randomness (maybe with an env var or flag to override the seed for reproducibility?).

Edit: I'm not aware of a deterministic test, but it seems this would have shown up all the time as a flake if the fuzzer were seeded better. I ran this test with 10000 seeds and it caught the bug around 75% of the time.

[benluddy]

/test pull-kubernetes-node-e2e-containerd

[liggitt]

/lgtm
/approve

mind picking to release-1.23 once this merges?

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benluddy, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiextensions-apiserver/pkg/apis/OWNERS [liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sttts]

trying to remember why these are hand-written and not generated

Did you remember? Is it because of the JSON types?

[liggitt]

Did you remember? Is it because of the JSON types?

yeah, attempting to autogenerate:

F0207 11:33:56.866152 66457 deepcopy.go:927] Hit an unsupported type k8s.io/apiextensions-apiserver/pkg/apis/apiextensions.JSON for *k8s.io/apiextensions-apiserver/pkg/apis/apiextensions.JSON

[liggitt]

looks like we can narrowly define DeepCopy for JSON and take advantage of generated deep copy code for the rest

[liggitt]

looks like we can narrowly define DeepCopy for JSON and take advantage of generated deep copy code for the rest

actually... defining that makes the generated deep copy files/functions look right, but go is unhappy with defining DeepCopy methods on JSON:

vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/deepcopy.go:21:6: invalid receiver type JSON (JSON is an interface type)
vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/zz_generated.deepcopy.go:442:13: (*in).DeepCopy undefined (type *JSON is pointer to interface, not interface)
vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/zz_generated.deepcopy.go:484:12: (*in)[i].DeepCopyInto undefined (type JSON is interface with no methods)
vendor/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/zz_generated.deepcopy.go:578:13: (*in).DeepCopy undefined (type *JSON is pointer to interface, not interface)

[leilajal]

/triage accepted