Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REQUEST: Create logtools #3356

Closed
RinkiyaKeDad opened this issue Apr 4, 2022 · 11 comments
Closed

REQUEST: Create logtools #3356

RinkiyaKeDad opened this issue Apr 4, 2022 · 11 comments
Assignees
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository

Comments

@RinkiyaKeDad
Copy link
Member

New repo, staging repo, or migrate existing

New repo

Is it a staging repo?

no

Requested name for new repository

logtools

Which Organization should it reside

kubernetes-sigs

Who should have admin access?

@ehashman, @logicalhan, @pohly, @serathius

Who should have write access?

@ehashman, @logicalhan, @pohly, @serathius

Who should be listed as approvers in OWNERS?

@ehashman, @logicalhan, @pohly, @dims, @serathius, @thockin

Who should be listed in SECURITY_CONTACTS?

@ehashman, @logicalhan, @pohly, @dims, @serathius, @thockin

What should the repo description be?

Tools related to log calls for Kubernetes.

What SIG and subproject does this fall under?

structured-logging subproject under sig-instrumentation

Please provide references to appropriate approval for this new repo

Additional context for request

No response

@RinkiyaKeDad RinkiyaKeDad added the area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository label Apr 4, 2022
@logicalhan
Copy link
Member

lgtm

2 similar comments
@serathius
Copy link
Contributor

lgtm

@pohly
Copy link
Contributor

pohly commented Apr 4, 2022

lgtm

@pohly
Copy link
Contributor

pohly commented Apr 26, 2022

@RinkiyaKeDad do you know whom to ping to get this PR merged?

@palnabarun
Copy link
Member

Will take a look shortly.
/assign

@pohly
Copy link
Contributor

pohly commented Jun 10, 2022

I have a branch ready that I can merge into the new repo:
https://github.com/pohly/klog/commits/logcheck

It was created with this file as logcheck-replacement.txt and the command in the comment:

# git-filter-repo --path hack/tools --prune-degenerate=always --no-ff --path-rename hack/tools/go.mod:go.mod --path-rename hack/tools/go.sum:go.sum --path-rename hack/tools/logcheck:logcheck --replace-message logcheck-replacement.txt --replace-text logcheck-replacement.txt
regex:Merge pull request #([0-9]+)==>Merge pull request https://github.com/kubernetes/klog/pull/\1
k8s.io/klog/hack/tools==>k8s.io/logtools
hack/tools: ==>

@palnabarun
Copy link
Member

The repo has been created: https://github.com/kubernetes-sigs/logtools

I've created #3496 to add the teams. Once it merges, I will add the teams to the repo. Also created kubernetes/community#6700 to add logtools to sigs.yaml.

Once the above merges, I will close this issue.

@pohly
Copy link
Contributor

pohly commented Jun 11, 2022

Looks good so far, thanks.

Just for my own understanding: what is the difference between "admin" and "write" access for a repo (https://github.com/kubernetes/org/pull/3496/files)?

@palnabarun
Copy link
Member

Admins get additional privileges like performing sensitive/destructive actions for example deleting issues, in comparison to people with write access.

@palnabarun
Copy link
Member

All the PRs have merged and the repository permissions have been updated. 🎉

/close

@k8s-ci-robot
Copy link
Contributor

@palnabarun: Closing this issue.

In response to this:

All the PRs have merged and the repository permissions have been updated. 🎉

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-repo Creating, migrating or deleting a Kubernetes GitHub Repository
Projects
None yet
Development

No branches or pull requests

6 participants