Validate empty package before analysing

[daemon1024]

What this PR does / why we need it:
Early return in case no packages in the provided directory, else execute the analyzer as usual

Which issue(s) this PR fixes
Fixes #214

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

[k8s-ci-robot]

Welcome @daemon1024!

It looks like this is your first PR to kubernetes/klog 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/klog has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[daemon1024]

From #220 (comment)

I suspect the best way to accomplish this may be to always return true if given a path that contains no Go files before starting the rest of the program logic. This would constitute input validation and is not the way the PR is currently written.

The change in this PR is more in line with what's mentioned in the above comment.

The caveat here is that we will be loading packages twice.
In case we don't want to do that.
The other way to handle the validation is, we walk through the directory to check if there are any go files present there or not.

Here's the commit daemon1024/klog@71d4862 using file walk.

Ref #214 (comment)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daemon1024
To complete the pull request process, please assign piosz after the PR has been reviewed.
You can assign the PR to them by writing /assign @piosz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[pohly]

I have a change ready that integrates logcheck into golangci-lint. Then golangci-lint covers package discovery and this change here is no longer needed.

/hold

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-ci-robot]

@daemon1024: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

/close

This will be solved via integration into golangci-lint: kubernetes/kubernetes#108159

[k8s-ci-robot]

@pohly: Closed this PR.

In response to this:

/close

This will be solved via integration into golangci-lint: kubernetes/kubernetes#108159

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.