openapi parsing performance improvement with protobuffer

[natasha41575]

Fixes #2987
Fixes #4100
Fixes #3670

Related: #4569

The performance improvement changes the format we use to parse our builtin openapi from JSON to proto. See kubernetes/kube-openapi#283, it reduces the parsing time from ~628ms to ~39ms.

You can see the performance improvement when running the example provided on this issue:

Previously:

$ time kustomize build
apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  name: example

real    0m0.670s
user    0m0.688s
sys     0m0.037s

With this branch:

$ time kustomize build
apiVersion: bitnami.com/v1alpha1
kind: SealedSecret
metadata:
  name: example

real    0m0.109s
user    0m0.114s
sys     0m0.029s

You can also see about a half second improvement in performance when running certain tests, e.g.

On master:

$ time go test -run TestPatchesInOneFile
PASS
ok      sigs.k8s.io/kustomize/api/krusty        0.902s

real    0m2.407s
user    0m2.540s
sys     0m1.120s

On this branch:

$ time go test -run TestPatchesInOneFile
PASS
ok      sigs.k8s.io/kustomize/api/krusty        0.343s

real    0m1.845s
user    0m1.990s
sys     0m1.144s

There is a separate PR to update the openapi scripts here: #4582

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

@natasha41575: This PR has multiple commits, and the default merge method is: merge.
You can request commits to be squashed using the label: tide/merge-method-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

@KnVerey @mengqiy Thank you for your patience and apologies for the long delay! The PR is updated and is ready for another review.

[mengqiy]

Looking at the implementation below, it seems we can handle json or yaml when the format is json.
Maybe we can call it JsonOrYaml

[natasha41575]

Good catch! Changed to JsonOrYaml

[mengqiy]

I wonder if we should use a newer version of the schema. Maybe v1.22?
It can be done in a followup PR.

[natasha41575]

Thanks! Yeah we were thinking about bumping the schema since we are pretty far behind. I filed #4583, let's discuss in a followup.

[mengqiy]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mengqiy, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [natasha41575]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[KnVerey]

One question, but not a blocker.

/lgtm

[KnVerey]

Why are these constants public but their type private?

[natasha41575]

I didn't see a purpose in making the type public, but I can see a potential use case in the future of passing in the format from another package once we start supporting user-provided proto schemas, hence why I made the const public.

I'm happy to change them to both being public or both being private if that makes more sense, I don't have a strong preference either way.

[natasha41575]

/hold cancel

[natasha41575]

Thanks everyone for the quick reviews!

[ephesused]

Thanks so much for this fix. It was very nice to see these results this morning...

Test_kustomize/kust-issue-2767/kustomize/branch-master (0.15s)
kustomize_test.go:182: Runtime variation (0.14x): branch-master ran in 143ms; release-v4.5.1 ran in 1000ms.

Test_kustomize/kust-issue-2808/kustomize/branch-master (0.13s)
kustomize_test.go:182: Runtime variation (0.13x): branch-master ran in 131ms; release-v4.5.1 ran in 1010ms.

Test_kustomize/kust-issue-2907/kustomize/branch-master (0.14s)
kustomize_test.go:182: Runtime variation (0.14x): branch-master ran in 138ms; release-v4.5.1 ran in 1022ms.

Test_kustomize/kust-issue-2987/kustomize/branch-master (0.13s)
kustomize_test.go:182: Runtime variation (0.13x): branch-master ran in 128ms; release-v4.5.1 ran in 997ms.

Test_kustomize/kust-issue-3157/kustomize/branch-master (0.14s)
kustomize_test.go:182: Runtime variation (0.13x): branch-master ran in 137ms; release-v4.5.1 ran in 1015ms.

Test_kustomize/kust-issue-3419/kustomize/branch-master (0.14s)
kustomize_test.go:182: Runtime variation (0.14x): branch-master ran in 135ms; release-v4.5.1 ran in 982ms.

[alexdyas]

Thanks @natasha41575!