Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kustomize dependencies #3026

Closed
wants to merge 1 commit into from
Closed

Conversation

natasha41575
Copy link
Contributor

Pick up the performance boost from kubernetes-sigs/kustomize#4568

@natasha41575
Copy link
Contributor Author

natasha41575 commented Apr 19, 2022

I found kubernetes/client-go#1075, which describes the issue that we are getting here.

The problem is that github.com/googleapis/gnostic was renamed to github.com/google/gnostic. Different dependencies are pulling in different names, so we get a bunch of errors because Go thinks that types from github.com/google/gnostic aren't the same as github.com/googleapis/gnostic

Ideally we would be able to upgrade all the dependencies to make this work, but it appears that we still have some (like k8s.io/cli-runtime) that still depend on the old name, while the newest kube-openapi depends on the new name (we need to upgrade kube-openapi to get the performance boost) - making them incompatible.

I'm not sure if there is any solution for this besides a replace statement.

Some other context: we had to make this gnostic name upgrade change in kustomize due to integration with kubectl: kubernetes-sigs/kustomize#4538

@yuwenma
Copy link
Contributor

yuwenma commented Apr 20, 2022

hit the same issue when bumping the set-namespace in porch #3028

@natasha41575 shall we bump the kyaml in all functions (set-namespace, starlark, apply-replacement) and sdk?

@mengqiy
Copy link
Contributor

mengqiy commented Apr 20, 2022

We need kubernetes-sigs/cli-utils#577

@mengqiy mengqiy closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants