🌱 Recreate checks always to keep them in the upper check suite

[Adirio]

As GitHub CheckRuns and CheckSuite API doesn't allow to bind Check Runs to Check Suites, reusing a CheckRun for any action is not a valid approach. Any action (open, reopen, edit, sync) creates a new Check Suite which is the one shown in the PR. If we reuse a previous Check Run (which we can't bind to this new Check Suite) it will be hidden in the previous Check Suite and, while its results will be updated and properly used, the check sections will not show the corresponding message.

This PR recreates checks always to keep them in the upper Check Suite of the stack so that they are showed in the checks section of a PR, unless until a way of binding Check Runs to Check Suites is provided by GitHub.

⚠️ I'm not 100% sure how this will behave as there will be multiple Check Runs with the same name for the same commit SHA. Theoretically they should be different Check Runs with different IDs, and the listing method filters just the latest one. But if this theoretic behavior is not the real one, a fix will need to be pushed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Adirio]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Adirio]

Proof of the issue that I'm tackling can be found comparing this PR, where only the first open action was issued, and therefore the checks section is complete.
On the other hand, #32's title was edited and the check runs are now not visible. They can be found by clicking on the "Details" link of the "PR Verifier / Verify PR contents (pull_request_target)" check, and then looking for them in the first Check Suite.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.