Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Updating a Check Run HeadSHA is not working #17

Closed
Adirio opened this issue Nov 18, 2020 · 3 comments 路 Fixed by #18 or #20
Closed

馃悰 Updating a Check Run HeadSHA is not working #17

Adirio opened this issue Nov 18, 2020 · 3 comments 路 Fixed by #18 or #20
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Adirio
Copy link
Contributor

Adirio commented Nov 18, 2020

Description

When a (force-)push is issued, the PR Verifier action tries to update the related check runs to the new commit. github.UpdateCheckRunOptions does provide a HeadSHA field but it is not updating the HeadSHA (potential GitHub actions bug). Therefore, we need to create a new CheckRun for the new commit instead of trying to rebind it.

Related: google/go-github#1652

@Adirio
Copy link
Contributor Author

Adirio commented Nov 19, 2020

#18 didn't solve the issue completely,
If the check runs weren't finished on synchornize, we are finishing and returning without making the duplicate for the new commit. We need to skip the return if finishing didn't yield any error.

@Adirio
Copy link
Contributor Author

Adirio commented Nov 19, 2020

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Nov 19, 2020
@k8s-ci-robot
Copy link
Contributor

@Adirio: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants