Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Open, edit and reopen not performing the checks #19

Closed
Adirio opened this issue Nov 18, 2020 · 0 comments 路 Fixed by #24
Closed

馃悰 Open, edit and reopen not performing the checks #19

Adirio opened this issue Nov 18, 2020 · 0 comments 路 Fixed by #24
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@Adirio
Copy link
Contributor

Adirio commented Nov 18, 2020

Description

open, edit and reopen actions are not performing the checks properly and the result is always a success.

Details

I will link the debug output for the steps that have happened to #14 as an example:

  1. Create a PR with wrong PR Title: success, no Check Run created log
  2. Edit the name to a correct one: success but no Check Run created log
  3. Edit the name to a incorrect one: success, no Check Run created log
  4. Edit the name to a correct one: success but no Check Run created log
  5. Close and reopen the PR: success but no Check Run created log
  6. Ammend commit to force a resynchronize: success, Check Run created in the wrong commit (tracked in 馃悰 Updating a Check Run HeadSHA is not working聽#17) log

As it can be seen in the first 5 steps (corresponding to open, edit, and reopen actions), none of them is providing any debug info and just seccessfully finishing the workflow without checking not creating the Check Runs. Step 6 does check and create the checks (with a bug tracked in #17 and solved in #18).

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 18, 2020
@Adirio Adirio changed the title Open, edit and reopen not performing the checks 馃悰 Open, edit and reopen not performing the checks Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants