fix: reuse gc name in GatewayClassObservedGenerationBump conformance

[Xunzhuo]

Signed-off-by: bitliu bitliu@tencent.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Xunzhuo
Once this PR has been reviewed and has the lgtm label, please assign caseydavenport for approval by writing /assign @caseydavenport in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• conformance/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[robscott]

Thanks for the work on this @Xunzhuo, added a comment to provide some more context. If I'm understanding correctly, it sounds like a single Envoy Gateway controller can't support multiple GatewayClasses?

/cc @dprotaso
/hold for consensus

[robscott]

There's some previous context here: #1586 (comment). There was also more discussion in the community meeting around that time.

I had 2 main concerns:

1. I didn't want to allow an existing resource to be mutated by conformance tests
2. I also wasn't convinced that every implementation would be able to support changes to arbitrary GatewayClasses

Making this change would go against 1 thought it would help with 2.

Eventually we agreed that these could be added if they were guarded by a feature gate and not part of the default test suite. @dprotaso can likely add some more context here as well.

[Xunzhuo]

Thanks @robscott! I think EG should support the multiple-GC model, and it makes sence : )

[dprotaso]

Yeah this test purposely mutates a second gateway class to test the observed generation is bumped in the status conditions when it is reconciled.

I believe changing the name to the default name GATEWAY_CLASS_NAME will (may?) break other tests since it's clearing params etc.

[k8s-ci-robot]

@robscott: GitHub didn't allow me to request PR reviews from the following users: dprotaso.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Thanks for the work on this @Xunzhuo, added a comment to provide some more context. If I'm understanding correctly, it sounds like a single Envoy Gateway controller can't support multiple GatewayClasses?

/cc @dprotaso
/hold for consensus

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[youngnick]

I've opened #1650 to cover updating the implementer's guide with some more info to clarify some of these issues.

[arkodg]

this shouldn't be needed if #1655 is accepted

[robscott]

Closing this out now that #1655 has merged, feel free to reopen if I missed anything.

/close

[k8s-ci-robot]

@robscott: Closed this PR.

In response to this:

Closing this out now that #1655 has merged, feel free to reopen if I missed anything.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.