Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Allow setting PreserveUnknownFields at both type and field level #701

Merged
merged 1 commit into from Jul 4, 2022
Merged

🐛 Allow setting PreserveUnknownFields at both type and field level #701

merged 1 commit into from Jul 4, 2022

Conversation

eddycharly
Copy link
Contributor

@eddycharly eddycharly commented Jul 4, 2022 •
edited

This is a manual cherry pick of #689 .

This is needed for #699

@eddycharly
fix: allow setting PreserveUnknownFields at both type and field level
d4c8962 
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @eddycharly. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 4, 2022
@eddycharly
Copy link
Contributor Author

/assign @FillZpp

@eddycharly eddycharly mentioned this pull request Jul 4, 2022
Closed
@FillZpp
Copy link
Contributor

FillZpp commented Jul 4, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 4, 2022
@FillZpp FillZpp mentioned this pull request Jul 4, 2022
Closed
@eddycharly eddycharly changed the title [release-0.9] 🐛 Allow setting PreserveUnknownFields at both type and field level 🐛 Allow setting PreserveUnknownFields at both type and field level Jul 4, 2022
@eddycharly
Copy link
Contributor Author

@FillZpp I had to remove [release-0.9] from the PR title.

@FillZpp
Copy link
Contributor

FillZpp commented Jul 4, 2022

/lgtm

/cc @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, eddycharly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@k8s-ci-robot k8s-ci-robot merged commit e03936f into kubernetes-sigs:release-0.9 Jul 4, 2022
@FillZpp FillZpp mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@droot droot Awaiting requested review from droot

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@FillZpp FillZpp

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eddycharly @k8s-ci-robot @FillZpp @alvaroaleman