Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-0.9] 🐛 Add XPreserveUnknownFields to runtime.RawExtension #699

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #683

/assign FillZpp

Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
Signed-off-by: Charles-Edouard Brétéché <charled.breteche@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
To complete the pull request process, please assign pwittrock after the PR has been reviewed.
You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eddycharly
Copy link
Contributor

Aren’t we going to need this one too #689 ?

@FillZpp
Copy link
Contributor

FillZpp commented Jul 4, 2022

Aren’t we going to need this one too #689 ?

Yeah, that should be cherry-picked first.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
@eddycharly
Copy link
Contributor

@FillZpp i think you need to remove [release-0.9] from the PR title.

@FillZpp
Copy link
Contributor

FillZpp commented Jul 5, 2022

@FillZpp i think you need to remove [release-0.9] from the PR title.

It doesn't matter, the title is generated by the robot. But it may not be able to rebase the latest release-0.9 branch since #701 has merged, so I'm going to reopen a new one.

/close

@k8s-ci-robot
Copy link
Contributor

@FillZpp: Closed this PR.

In response to this:

@FillZpp i think you need to remove [release-0.9] from the PR title.

It doesn't matter, the title is generated by the robot. But it may not be able to rebase the latest release-0.9 branch since #701 has merged, so I'm going to reopen a new one.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants