✨ Add indexes to fake client to mimic field selectors #2025

matteoolivi · 2022-10-18T15:30:09Z

Allow registration of indexes into the fake client to allow usage of field selectors when doing a List. The indexing is done lazily by doing a normal list and then filtering the results by computing the index value for each list item.

To enable the main change for this commit, some refactorings are performed: an internal and unexported function that checks whether a field selector is in the form key=val or key==val is made internal and exported to be shared between real and faked code to ensure loyalty. Unit tests for it are added.

Co-authored-by: Paul Eichler peichler@anynines.com

This PR addresses #1948 (comment) and is a reincarnation of #800

k8s-ci-robot · 2022-10-18T15:30:20Z

Hi @matteoolivi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Allow registration of indexes into the fake client to allow usage of field selectors when doing a List. The indexing is done lazily by doing a normal list and then filtering the results by computing the index value for each list item. To enable the main change for this commit, some refactorings are performed: an internal and unexported function that checks whether a field selector is in the form key=val or key==val is made internal and exported to be shared between real and faked code to ensure loyalty. Unit tests for it are added. Co-authored-by: Paul Eichler <peichler@anynines.com>

alvaroaleman

/ok-to-test

alvaroaleman · 2022-10-21T15:59:14Z

pkg/client/fake/client.go

+// API objects of GroupVersionResource `gvr` in the fake client.
+// It can be invoked multiple times, both with different GroupVersionResource or the same one.
+// Invoking WithIndex twice with the same `name` and `gvr` will panic.
+func (f *ClientBuilder) WithIndex(gvr schema.GroupVersionResource, name string, indexer client.IndexerFunc) *ClientBuilder {


rather than taking an gvr, could we take a client.Object instead? And maybe stick with the argument naming used in the FieldIndexer (i.E. obj Object, field string, extractValue IndexerFunc)?

Done in 5db9d19

alvaroaleman · 2022-10-21T16:07:19Z

pkg/client/fake/client.go

+
+	// Field selection is mimicked via indexes, so there's no sane answer this function can give
+	// if there are no indexes registered for the GroupVersionResource of the objects in the list.
+	indexes, listGVRHasIndexes := c.indexes[gvr]


I think we should return the same error for this and the second error condition, for the user of this it is the same mistake so getting one or the other might be confusing because what they have to change is the same in both cases

Suggested change

indexes, listGVRHasIndexes := c.indexes[gvr]

if indexes := c.indexes[gvr]; indexers == nil || indexers[fieldKey] == nil {

return nil, fmt.Errorf(...

}

Done in 5db9d19

alvaroaleman · 2022-10-21T16:08:54Z

pkg/client/fake/client_test.go

@@ -86,7 +100,7 @@ var _ = Describe("Fake client", func() {
 		}
 	})

-	AssertClientBehavior := func() {
+	AssertClientWOIndexBehavior := func() {


Suggested change

AssertClientWOIndexBehavior := func() {

AssertClientWithoutIndexBehavior := func() {

Done in 5db9d19

matteoolivi · 2022-10-24T01:40:04Z

@alvaroaleman I pushed a separate commit to address your change requests.

matteoolivi · 2022-10-24T11:33:43Z

/retest

alvaroaleman

thanks!

k8s-ci-robot · 2022-10-26T21:43:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, matteoolivi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [alvaroaleman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alvaroaleman · 2022-10-26T21:50:38Z

looks like we have some flaky tests

/retest

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

See the unintentional breaking change in: kubernetes-sigs/controller-runtime#2025 Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

See the unintentional breaking change in: kubernetes-sigs/controller-runtime#2025 There's now an error thrown if a field selector is used but an index wasn't registered but previously it was simply ignored. Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

…5541) * chore(deps): bump sigs.k8s.io/controller-tools from 0.10.0 to 0.11.1 Bumps [sigs.k8s.io/controller-tools](https://github.com/kubernetes-sigs/controller-tools) from 0.10.0 to 0.11.1. - [Release notes](https://github.com/kubernetes-sigs/controller-tools/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-tools/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-tools@v0.10.0...v0.11.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-tools dependency-type: direct:production update-type: version-update:semver-minor ... * chore(deps): bump sigs.k8s.io/controller-runtime from 0.13.1 to 0.14.1 Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.13.1 to 0.14.1. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.13.1...v0.14.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... * fix: check AddEventHandler error * fix: deprecated functions * chore: update CRDs * chore: update golden files * fix: use index in test See the unintentional breaking change in: kubernetes-sigs/controller-runtime#2025 There's now an error thrown if a field selector is used but an index wasn't registered but previously it was simply ignored. Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Mike Beaumont <mjboamail@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mike Beaumont <mjboamail@gmail.com>

…troller-runtime controller-runtime 0.14 includes kubernetes-sigs/controller-runtime#2025 which turned out to be a breaking change for any tests that use fake controller-runtime client for list operations against the index. This commit addresses that, by extracting the indexer func out of the reconciler setup function so that both the reconciler setup func and the set-only fake client setup func can use the same indexer func. This fixes integration errors like the below example: ``` --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel (0.00s) --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel/Successful (0.00s) horizontal_runner_autoscaler_webhook_test.go:256: status: 500 horizontal_runner_autoscaler_webhook_test.go:256: body: List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler horizontal_runner_autoscaler_webhook_test.go:440: diagnostics: testlog] finding repository-wide runnerrepository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued delivery= workflowJob.labels=[self-hosted label1] workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 event=workflow_job hookID= repository=MYORG/MYREPO error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler testlog] handling check_run eventevent=workflow_job hookID= workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 delivery= workflowJob.labels=[self-hosted label1] repository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler ```

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

…troller-runtime controller-runtime 0.14 includes kubernetes-sigs/controller-runtime#2025 which turned out to be a breaking change for any tests that use fake controller-runtime client for list operations against the index. This commit addresses that, by extracting the indexer func out of the reconciler setup function so that both the reconciler setup func and the set-only fake client setup func can use the same indexer func. This fixes integration errors like the below example: ``` --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel (0.00s) --- FAIL: TestWebhookWorkflowJobWithSelfHostedLabel/Successful (0.00s) horizontal_runner_autoscaler_webhook_test.go:256: status: 500 horizontal_runner_autoscaler_webhook_test.go:256: body: List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler horizontal_runner_autoscaler_webhook_test.go:440: diagnostics: testlog] finding repository-wide runnerrepository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued delivery= workflowJob.labels=[self-hosted label1] workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 event=workflow_job hookID= repository=MYORG/MYREPO error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler testlog] handling check_run eventevent=workflow_job hookID= workflowJob.status=queued enterprise.slug= workflowJob.runID=1234567890 workflowJob.ID=1234567890 delivery= workflowJob.labels=[self-hosted label1] repository.name=MYREPO repository.owner.login=MYORG repository.owner.type=Organization action=queued error=List on GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler specifies selector on field scaleTarget, but no index with name scaleTarget has been registered for GroupVersionKind actions.summerwind.dev/v1alpha1, Kind=HorizontalRunnerAutoscaler ``` Signed-off-by: Yusuke Kuoka <ykuoka@gmail.com>

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

…`v0.14.1` (#7248) * Update `k8s.io/*` to `v0.26.0` * Update `sigs.k8s.io/controller-runtime` to `v0.14.1` * Set `RecoverPanic` globally for the manager of `controller-manager` controllers * Set `RecoverPanic` globally for the manager of `gardenlet` controllers * Set `RecoverPanic` globally for the manager of `operator` controllers * Set `RecoverPanic` globally for the manager of `resource-manager` controllers * Set `RecoverPanic` globally for the manager of `scheduler` controllers * Set `RecoverPanic` globally in manager options for extension controllers * Change RecoverPanic bool to bool pointer for other controllers * Run `make generate` * Set `AllowInvalidLabelValueInSelector` to true in LabelSelectorValidationOptions for backwards compatibility See kubernetes/kubernetes#113699 for more details * Drop `Not` predicate util function in favor of controller-runtime `predicate.Not` * Drop `NewClientWithFieldSelectorSupport` function in favor of controller-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025 * Use `Build()` function for all controllers * Use Subresource client for `shoots/binding` and drop generated clientset * Use Subresource client for `shoots/adminkubeconfig` and drop generated clientset * Use Status() client for Status Ref: kubernetes-sigs/controller-runtime#2072 * Adapt unit tests with mock StatusWriter * Add "ValidatingAdmissionPolicy" to default admission plugins * Adapt changes related to removed fields in kube-proxy config * Add unit test cases for "#IsAdmissionPluginSupported" function * Update envtest version * Return error from `informer.AddEventHandler` * Copy onsi/gomega/format package also to gomegacheck testdata * Address PR review feedback * Vendor current `etcd-druid` master * Use `builder.Watches()` wherever possible * Call `etcdOptions.Complete()` for gardener apiserver config etcd-encryption is supported out-of-the-box now. ref: kubernetes/kubernetes#112789 * Use Subresource client for `serviceaccounts/token` wherever possible * Update `ahmetb/gen-crd-api-reference-docs` to `0.3.0` * Update `sigs.k8s.io/controller-tools` to `v0.11.0` Update to `v0.11.1` once kubernetes/kubernetes/pull/114617 is released. In k8s v0.26.0 the CRD generation is broken. * Remove unneeded dependencies for `gardener-scheduler` from skaffold.yaml * Hardcode `RecoverPanic` to true for extensions controller * Use `k8s.io/apimachinery/pkg/util/sets` and drop copied packages * Drop ready check for garden informer sync for gardenlet Adding ready check to manager is not possible after it's started, since controller-runtime, `v0.11.0`. However the check was broken, and it is now fixed in kubernetes-sigs/controller-runtime#2090, so we have to drop this. * Adapt `provider-local` webhook * Address PR review feedback * Fix panic in ManagedSeed controller Contexts: from this PR, we're not setting RecoverPanic to true in tests * Vendor `etcd-druid` `v0.15.3` * Update `k8s.io/*` and `controller-runtime` k8s.io/* - 0.26.0=>0.26.1 controller-tools - 0.11.0=>0.11.1 * Run `make generate` * Rebase * Address PR review feedback * Fix failing test * Adapt `highavailabilityconfig` webhook integration test `autoscaling/v2beta2.HorizontalPodAutoscaler` is removed in v1.26. Ref: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-26 * Use `apiutil.NewDynamicRESTMapper` for Manager cache in tests Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Don't set `RecoverPanic` for os extensions in AddToManager This is not required since we call `mgrOpts.Options()` here : https://github.com/gardener/gardener/blob/c9cb564d1adad0a1ecf9d44f23fb249bcf946a79/extensions/pkg/controller/operatingsystemconfig/oscommon/app/app.go#L88 * Truncate time in test to microsecond precision Ref: kubernetes/kubernetes#111936 * Rebase --------- Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

controller-runtime deprecated the envtest/printer package in v0.14.0. They don't needed anymore since they upgraded to ginko v2. In order to keep the scope contained, I just copied the code we needed, it's quite simple. This allow us to maintain the same version of ginko while bumping controller-runtime. The fake client provided by controller-runtime was updated to allow for field selectors in List operations. This requires to define the index prior to its use. Since the Job controller uses ".metadata.controller" for a List query, we now set this index in the tests client. kubernetes-sigs/controller-runtime#2025 Signed-off-by: Guillermo Gaston <gaslor@amazon.com>

…`v0.14.1` (gardener#7248) * Update `k8s.io/*` to `v0.26.0` * Update `sigs.k8s.io/controller-runtime` to `v0.14.1` * Set `RecoverPanic` globally for the manager of `controller-manager` controllers * Set `RecoverPanic` globally for the manager of `gardenlet` controllers * Set `RecoverPanic` globally for the manager of `operator` controllers * Set `RecoverPanic` globally for the manager of `resource-manager` controllers * Set `RecoverPanic` globally for the manager of `scheduler` controllers * Set `RecoverPanic` globally in manager options for extension controllers * Change RecoverPanic bool to bool pointer for other controllers * Run `make generate` * Set `AllowInvalidLabelValueInSelector` to true in LabelSelectorValidationOptions for backwards compatibility See kubernetes/kubernetes#113699 for more details * Drop `Not` predicate util function in favor of controller-runtime `predicate.Not` * Drop `NewClientWithFieldSelectorSupport` function in favor of controller-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025 * Use `Build()` function for all controllers * Use Subresource client for `shoots/binding` and drop generated clientset * Use Subresource client for `shoots/adminkubeconfig` and drop generated clientset * Use Status() client for Status Ref: kubernetes-sigs/controller-runtime#2072 * Adapt unit tests with mock StatusWriter * Add "ValidatingAdmissionPolicy" to default admission plugins * Adapt changes related to removed fields in kube-proxy config * Add unit test cases for "#IsAdmissionPluginSupported" function * Update envtest version * Return error from `informer.AddEventHandler` * Copy onsi/gomega/format package also to gomegacheck testdata * Address PR review feedback * Vendor current `etcd-druid` master * Use `builder.Watches()` wherever possible * Call `etcdOptions.Complete()` for gardener apiserver config etcd-encryption is supported out-of-the-box now. ref: kubernetes/kubernetes#112789 * Use Subresource client for `serviceaccounts/token` wherever possible * Update `ahmetb/gen-crd-api-reference-docs` to `0.3.0` * Update `sigs.k8s.io/controller-tools` to `v0.11.0` Update to `v0.11.1` once kubernetes/kubernetes/pull/114617 is released. In k8s v0.26.0 the CRD generation is broken. * Remove unneeded dependencies for `gardener-scheduler` from skaffold.yaml * Hardcode `RecoverPanic` to true for extensions controller * Use `k8s.io/apimachinery/pkg/util/sets` and drop copied packages * Drop ready check for garden informer sync for gardenlet Adding ready check to manager is not possible after it's started, since controller-runtime, `v0.11.0`. However the check was broken, and it is now fixed in kubernetes-sigs/controller-runtime#2090, so we have to drop this. * Adapt `provider-local` webhook * Address PR review feedback * Fix panic in ManagedSeed controller Contexts: from this PR, we're not setting RecoverPanic to true in tests * Vendor `etcd-druid` `v0.15.3` * Update `k8s.io/*` and `controller-runtime` k8s.io/* - 0.26.0=>0.26.1 controller-tools - 0.11.0=>0.11.1 * Run `make generate` * Rebase * Address PR review feedback * Fix failing test * Adapt `highavailabilityconfig` webhook integration test `autoscaling/v2beta2.HorizontalPodAutoscaler` is removed in v1.26. Ref: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-26 * Use `apiutil.NewDynamicRESTMapper` for Manager cache in tests Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Don't set `RecoverPanic` for os extensions in AddToManager This is not required since we call `mgrOpts.Options()` here : https://github.com/gardener/gardener/blob/c9cb564d1adad0a1ecf9d44f23fb249bcf946a79/extensions/pkg/controller/operatingsystemconfig/oscommon/app/app.go#L88 * Truncate time in test to microsecond precision Ref: kubernetes/kubernetes#111936 * Rebase --------- Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 18, 2022

k8s-ci-robot requested review from pwittrock and varshaprasad96 October 18, 2022 15:30

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 18, 2022

matteoolivi mentioned this pull request Oct 18, 2022

Add support for fieldSelector to fakeClient #1948

Closed

matteoolivi force-pushed the add_field_selectors_to_fake_client branch from c9fa5e7 to c8aad1d Compare October 18, 2022 21:02

alvaroaleman reviewed Oct 21, 2022

View reviewed changes

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2022

Address review comments

5db9d19

alvaroaleman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Oct 26, 2022

alvaroaleman approved these changes Oct 26, 2022

View reviewed changes

k8s-ci-robot assigned alvaroaleman Oct 26, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2022

k8s-ci-robot merged commit 4c9c956 into kubernetes-sigs:master Oct 26, 2022

matteoolivi deleted the add_field_selectors_to_fake_client branch October 26, 2022 22:57

shafeeqes mentioned this pull request Dec 19, 2022

Upgrade k8s.io/* to v0.26, sigs.k8s.io/controller-runtime to v0.14 gardener/gardener#7230

Closed

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

e5c969c

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

9c1ef49

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

1c599c1

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

5b97498

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

9aabdb8

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 20, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

501f4f0

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 21, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

3429791

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 21, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

2c65c0b

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Dec 21, 2022

Drop NewClientWithFieldSelectorSupport function in favor of control…

5f57288

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

triffer mentioned this pull request Dec 22, 2022

Add support for pod status.phase field selector in fake client kyma-project/istio#50

Merged

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 2, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

2a5cae1

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 9, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

75c2875

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime#2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 11, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

42a9571

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 12, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

24a1e27

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 16, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

85628af

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

sbueringer mentioned this pull request Jan 16, 2023

Follow-up tasks for CR bump to v0.14.0 kubernetes-sigs/cluster-api#7925

Closed

4 tasks

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 19, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

2a5c844

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

michaelbeaumont added a commit to kumahq/kuma that referenced this pull request Jan 19, 2023

fix: use index in test

861123a

See the unintentional breaking change in: kubernetes-sigs/controller-runtime#2025 Signed-off-by: Mike Beaumont <mjboamail@gmail.com>

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 23, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

fba0594

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 24, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

05e77e3

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 27, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

c5dbf2e

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

shafeeqes added a commit to shafeeqes/gardener that referenced this pull request Jan 30, 2023

Drop NewClientWithFieldSelectorSupport function in favor of control…

3fb7284

…ler-runtime `WithIndex` function kubernetes-sigs/controller-runtime/pull/2025

g-gaston mentioned this pull request Feb 9, 2023

Update controller-runtime to v0.14.4 tinkerbell/rufio#78

Merged

3 tasks

kerthcet mentioned this pull request Feb 22, 2023

Add indexer to fakeCilent when bumping k8s.io deps to v0.26.1 kubernetes-sigs/kueue#588

Merged

mihaialexandrescu mentioned this pull request May 24, 2023

Update cert-manager dependency libraries to 1.11.2 banzaicloud/koperator#981

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ Add indexes to fake client to mimic field selectors #2025

✨ Add indexes to fake client to mimic field selectors #2025

matteoolivi commented Oct 18, 2022

k8s-ci-robot commented Oct 18, 2022

alvaroaleman left a comment

alvaroaleman Oct 21, 2022

matteoolivi Oct 24, 2022

alvaroaleman Oct 21, 2022

matteoolivi Oct 24, 2022

alvaroaleman Oct 21, 2022

matteoolivi Oct 24, 2022

matteoolivi commented Oct 24, 2022

matteoolivi commented Oct 24, 2022

alvaroaleman left a comment

k8s-ci-robot commented Oct 26, 2022

alvaroaleman commented Oct 26, 2022

-	indexes, listGVRHasIndexes := c.indexes[gvr]
+	if indexes  := c.indexes[gvr]; indexers == nil || indexers[fieldKey] == nil {
+	     return nil, fmt.Errorf(...
+	}

	AssertClientWOIndexBehavior := func() {
	AssertClientWithoutIndexBehavior := func() {

✨ Add indexes to fake client to mimic field selectors #2025

✨ Add indexes to fake client to mimic field selectors #2025

Conversation

matteoolivi commented Oct 18, 2022

k8s-ci-robot commented Oct 18, 2022

alvaroaleman left a comment

Choose a reason for hiding this comment

alvaroaleman Oct 21, 2022

Choose a reason for hiding this comment

matteoolivi Oct 24, 2022

Choose a reason for hiding this comment

alvaroaleman Oct 21, 2022

Choose a reason for hiding this comment

matteoolivi Oct 24, 2022

Choose a reason for hiding this comment

alvaroaleman Oct 21, 2022

Choose a reason for hiding this comment

matteoolivi Oct 24, 2022

Choose a reason for hiding this comment

matteoolivi commented Oct 24, 2022

matteoolivi commented Oct 24, 2022

alvaroaleman left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Oct 26, 2022

alvaroaleman commented Oct 26, 2022