Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s.io/* to v0.26, sigs.k8s.io/controller-runtime to v0.14 #7230

Closed
rfranzke opened this issue Dec 19, 2022 · 3 comments · Fixed by #7248
Closed

Upgrade k8s.io/* to v0.26, sigs.k8s.io/controller-runtime to v0.14 #7230

rfranzke opened this issue Dec 19, 2022 · 3 comments · Fixed by #7248
Assignees
Labels
area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension

Comments

@rfranzke
Copy link
Member

How to categorize this issue?

/area open-source dev-productivity
/kind enhancement

What would you like to be added:

We should upgrade to the latest versions of our go upstream dependencies:

Important changes / Action items

Here is a list of a few upstream changes to look out for when vendoring g/g, k/* and c-r in any of our repos (e.g. extensions). Please consider the release notes of controller-runtime@v0.14 and upwards as well for a more complete list and more details.

⚠️ breaking / most notable changes

ℹ️ other changes / good to know / for information only:

@gardener-prow gardener-prow bot added area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels Dec 19, 2022
@shafeeqes
Copy link
Contributor

shafeeqes commented Dec 19, 2022

"Add indexes to fake client to mimic field selectors" (kubernetes-sigs/controller-runtime#2025) is also included in v.14.0, which can probably replace

// NewClientWithFieldSelectorSupport takes a fake client and a function that returns selectable fields for the type T
// and adds support for field selectors to the client.
// TODO(plkokanov): remove this once the controller-runtime fake client supports field selectors.
func NewClientWithFieldSelectorSupport[T any](c client.Client, toSelectableFieldsFunc func(t *T) fields.Set) client.Client {
return &clientWithFieldSelectorSupport[T]{
Client: c,
toSelectableFieldsFunc: toSelectableFieldsFunc,
}
}

@shafeeqes
Copy link
Contributor

/assign

@shafeeqes
Copy link
Contributor

The controller builder does not require For() anymore (ref kubernetes-sigs/controller-runtime#2091). However, this seems to be buggy with 0.14.0, ref kubernetes-sigs/controller-runtime#2101, so we cannot use it yet.

kubernetes-sigs/controller-runtime#2101 is fixed in kubernetes-sigs/controller-runtime#2105 and released with v0.14.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dev-productivity Developer productivity related (how to improve development) area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/enhancement Enhancement, improvement, extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants