Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/golang/protobuf from 1.3.1 to 1.4.3 in /vendor/google.golang.org/appengine #414

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jan 25, 2021

Bumps github.com/golang/protobuf from 1.3.1 to 1.4.3.

Release notes

Sourced from github.com/golang/protobuf's releases.

v1.4.3

Notable changes:

(#1221) jsonpb: Fix marshaling of Duration (#1210) proto: convert integer to rune before converting to string

v1.4.2

Notable changes:

  • (#1131) all: upgrade to google.golang.org/protobuf@v1.23.0
  • (#1125) jsonpb: fix a confusing error message
  • (#1129) proto: make InternalMessageInfo functional

v1.4.1

Notable changes:

  • (#1114) all: upgrade to google.golang.org/protobuf@v1.22.0
  • (#1113) protoc-gen-go/grpc: make identical to v1.3.5

v1.4.0

Overview

This release of the github.com/golang/protobuf module introduces a number of significant changes relative to the previous minor release. In particular, this module is now implemented in terms of the new google.golang.org/protobuf module, which is the next major revision of Go bindings for protocol buffers. From this point onwards, most of the development effort for Go protobufs will be dedicated to the new module, with minimal changes being made to this module.

See the release notes for the new module for specific implementation details that may affect this release.

Backwards compatibility

This release maintains backwards compatibility with previous releases of this module. Any observable changes in behavior are to fix bugs, change unspecified behavior, or to make behavior more compliant with the protobuf specification. The compatibility document provides us the freedom to make changes in these areas.

Notable changes

Wire serialization

Wire serialization is now implemented in terms of the new proto package by calling out to the relevant functionality in that package (e.g., proto.Marshal and proto.Unmarshal). There should be no observable changes in behavior other what is mentioned elsewhere in the release notes (e.g., behavior around errors or nil values).

... (truncated)

Commits
  • 4846b58 jsonpb: Fix marshaling of Duration (#1221)
  • 91c84e0 travis.yml: update tested versions of Go (#1211)
  • 3860b27 proto: convert integer to rune before converting to string (#1210)
  • d04d7b1 all: upgrade to google.golang.org/protobuf@v1.23.0 (#1131)
  • 07c14f1 proto: make InternalMessageInfo functional (#1129)
  • 00998c7 jsonpb: fix a confusing error message (#1125)
  • 6c66de7 all: upgrade to google.golang.org/protobuf@v1.22.0 (#1114)
  • b5de78c all: minor documentation adjustments (#1112)
  • 8d9af28 protoc-gen-go/grpc: make grpc identical to v1.3.5 (#1113)
  • fa093f5 proto: fix stale deprecation documentation on registry functions (#1093)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/golang/protobuf](https://github.com/golang/protobuf) from 1.3.1 to 1.4.3.
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.3.1...v1.4.3)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jan 25, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Jan 25, 2021

Dependabot tried to add @GarnettWang, @xiaozhouX and @osswangxining as reviewers to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/kubeflow/arena/pulls/414/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the kubeflow/arena repository. // See: https://docs.github.com/rest/reference/pulls#request-reviewers-for-a-pull-request

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dependabot[bot]
To complete the pull request process, please assign cheyang after the PR has been reviewed.
You can assign the PR to them by writing /assign @cheyang in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Mar 18, 2021

Superseded by #506.

@dependabot dependabot bot closed this Mar 18, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/vendor/google.golang.org/appengine/github.com/golang/protobuf-1.4.3 branch March 18, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants