Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: fix stale deprecation documentation on registry functions #1093

Merged

Conversation

marcellanz
Copy link
Contributor

Fixes #1092 "registry: FileDescriptor should mention protoregistry.GlobalFiles.FindFileByPath as replacement"

@dsnet
Copy link
Member

dsnet commented Apr 19, 2020

Thanks! We might as well fix the other stale deprecation notices:

  • L32 should say protoregistry.GlobalFiles.RegisterFile.
  • L101 should say protoregistry.GlobalTypes.RegisterEnum.
  • L184 should say protoregistry.GlobalTypes.RegisterMessage.
  • L283 should say protoregistry.GlobalTypes.RegisterExtension.

@marcellanz
Copy link
Contributor Author

marcellanz commented Apr 19, 2020

I amended them to this PR.

@dsnet dsnet changed the title [deprecation-note] Mention protoregistry.GlobalFiles.FindFileByPath as replacement for FileDescriptor. proto: fix stale deprecation documentation on registry functions Apr 19, 2020
@dsnet dsnet merged commit fa093f5 into golang:master Apr 19, 2020
obase added a commit to obase/protobuf that referenced this pull request Apr 30, 2020
proto: fix stale deprecation documentation on registry functions (golang#1093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

registry: FileDescriptor should mention protoregistry.GlobalFiles.FindFileByPath as replacement
2 participants