Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustls,hyper-rustls - for #1181 #1182

Merged
merged 5 commits into from Apr 3, 2023
Merged

Bump rustls,hyper-rustls - for #1181 #1182

merged 5 commits into from Apr 3, 2023

Conversation

clux
Copy link
Member

@clux clux commented Apr 3, 2023

Dependency upgrades for rustls:

A few things to note:

  • handling windows* duplicate dependency failures from deny aggressively (since there were tons)
  • whitelists the same license that webpki used (rustls-webpki fork now included)
  • possibly solves rustls ip issue: rustls cannot reach a cluster through ip #153 (comment) due to the fork inclusion

Leftover dependabot PRs that needed to go together.

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux added dependencies upgrades to dependencies changelog-exclude changelog excluded prs labels Apr 3, 2023
@clux clux added this to the 0.81.0 milestone Apr 3, 2023
@clux clux mentioned this pull request Apr 3, 2023
6 tasks
clux added 2 commits April 3, 2023 18:37
Signed-off-by: clux <sszynrae@gmail.com>
we don't need to be as strict with versions on this platform

Signed-off-by: clux <sszynrae@gmail.com>
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1182 (7a012b1) into main (b1cd5f2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1182   +/-   ##
=======================================
  Coverage   73.46%   73.46%           
=======================================
  Files          68       68           
  Lines        5355     5355           
=======================================
  Hits         3934     3934           
  Misses       1421     1421           
Impacted Files Coverage Δ
kube-client/src/client/tls.rs 79.16% <ø> (ø)

Signed-off-by: clux <sszynrae@gmail.com>
@clux
Copy link
Member Author

clux commented Apr 3, 2023

Ugh. pem v2.0.0 cannot be built because it requires rustc 1.67.0 or newer, while the currently active rustc version is 1.63.0 (from MSRV check).

That's only one stable behind which is not ideal for us. Probably means we have to give this one a miss for 0.81

Possibly only bumped for a CI change upstream -> commit? Left a comment about it to see if it was intentionally strict.

EDIT: have backed out pem instead and left it for later in #1181

@clux clux removed this from the 0.81.0 milestone Apr 3, 2023
Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Bump pem,rustls,hyper-rustls - for #1181 Bump rustls,hyper-rustls - for #1181 Apr 3, 2023
@clux clux added this to the 0.81.0 milestone Apr 3, 2023
@clux clux marked this pull request as ready for review April 3, 2023 18:24
@clux clux requested a review from kazk April 3, 2023 18:43
@clux clux merged commit 7e75fdc into main Apr 3, 2023
18 checks passed
@clux clux deleted the bump-pem-rustls-hyper branch April 3, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants