Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run rustls CI against IP cluster address #1183

Merged
merged 1 commit into from Apr 3, 2023
Merged

Run rustls CI against IP cluster address #1183

merged 1 commit into from Apr 3, 2023

Conversation

clux
Copy link
Member

@clux clux commented Apr 3, 2023

This actually means that #153 is really, actually fixed. The fix comes through from an innocuous rustls+hyper-rustls bump in #1182, which will be available in 0.81.

Tested locally with a fresh k3d cluster at 1.25 with the default server: https://0.0.0.0:39555 (normally you would have to replace 0.0.0.0 with localhost to make it work).

Before

$ cargo run --example pod_watcher --no-default-features --features=rustls-tls,latest,runtime

    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `/home/clux/kube/kube/target/debug/examples/pod_watcher`
2023-04-03T19:15:47.113789Z  WARN rustls::conn: Sending fatal alert BadCertificate
2023-04-03T19:15:47.113902Z ERROR kube_client::client::builder: failed with error error trying to connect: presented server name type wasn't supported
Error: failed to perform initial object list: HyperError: error trying to connect: presented server name type wasn't supported

Caused by:
    0: HyperError: error trying to connect: presented server name type wasn't supported
    1: error trying to connect: presented server name type wasn't supported
    2: presented server name type wasn't supported

After

$ cargo run --example pod_watcher --no-default-features --features=rustls-tls,latest,runtime
    Finished dev [unoptimized + debuginfo] target(s) in 0.10s
     Running `/home/clux/kube/kube/target/debug/examples/pod_watcher`
2023-04-03T19:16:25.836883Z  INFO pod_watcher: saw local-path-provisioner-79f67d76f8-gsnkz

Signed-off-by: clux <sszynrae@gmail.com>
@clux clux changed the title Run rustls checks against IP in cluster Run rustls CI against IP cluster address Apr 3, 2023
@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #1183 (a43b8d0) into main (7e75fdc) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1183      +/-   ##
==========================================
+ Coverage   73.46%   73.48%   +0.01%     
==========================================
  Files          68       68              
  Lines        5355     5355              
==========================================
+ Hits         3934     3935       +1     
+ Misses       1421     1420       -1     

see 1 file with indirect coverage changes

@clux clux linked an issue Apr 3, 2023 that may be closed by this pull request
@clux clux added the changelog-fix changelog fix category for prs label Apr 3, 2023
@clux clux added this to the 0.81.0 milestone Apr 3, 2023
@clux clux marked this pull request as ready for review April 3, 2023 19:42
@clux clux merged commit 752d9d3 into main Apr 3, 2023
18 checks passed
@clux clux deleted the rustls-verification branch April 3, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustls cannot reach a cluster through ip
1 participant