fix: only stringify JSON if insert value is an array containing plain object #5444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why was this closed? |
|
@kibertoad, closed following the comment by @caseywebdev here #5430 (comment) at the beginning I want to submit a PR to fix a regression introduced by #5320 in our codebase (cannot insert array of string to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5430 regression
The regression is introduced in PR follow from a feature requested 5320
this PR is to add an extra check for value, the check is now also check if the value is an array and containing at least one plain object.
the PR is trying to refine the feature implemented by @mingoing (rather than rollback the commit)
also add some tests heavily influenced by the PR from @loren138 (#5439)