tests(insert): add insert tests for json, text array and integer array #5451
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: add various tests case for the PR #5431 (rollback of #5321)
text array
column Malformed array literal: Knex 2.4.0 regression #5430integer array
column Inserting into PostgreSQL array columns are broken on master branch #5365text array
column Inserting into PostgreSQL array columns are broken on master branch #5365jsonb
columnthe PR #5431 by @caseywebdev should be merged first
A little bit more explanation:
#5365 : user want to insert array of string into
text array
column, or array of integer intointeger array
column, which is valid and should be inserted, but the PR #5321 merged sometime ago break it (it will always stringify the array to json string)@kibertoad At first I thought I can add a check for Array containing at least one plainObject with my previous PR #5444, but turn out it will not solve the #5430, my previous changes will need user to input a valid array of string into
text array
column#5430 : user want to insert array of object into
text array
column (worked in previous version of knex). the PR #5321 break it (it will always stringify the array of object to json string)